chore(tests): loosen workspace-mounts perf ceiling to catastrophe-only#358
Merged
Conversation
The `performance_tests` in workspace_mounts.rs asserted a 200ms average wall-clock ceiling over the workspace-discovery + mount-rendering hot path. Two of them do real filesystem canonicalization / git-root detection, which can spike under nextest's parallel load (worst on Windows' locking FS), making the precise bound a flaky-fail risk on the fast lane. Keep the functional per-iteration assertions (they still guard correctness on every run) but raise the bound to a deliberately generous 5s so it can only trip on a genuine hang or an order-of-magnitude regression, never on ordinary CI jitter. Documented the rationale on the constant. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019vhr7Tcf8ybvSZSE1owqBT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the flaky wall-clock assertions in
workspace_mounts.rs'sperformance_tests(finding #2 from a flaky-test sweep).These tests asserted a 200ms average wall-clock ceiling over the workspace-discovery + mount-rendering hot path. Two of them (
test_workspace_discovery_performance,test_combined_workspace_and_mount_performance) do real filesystem canonicalization / git-root detection, which can spike under nextest's parallel load — worst on Windows' locking filesystem — making a precise wall-clock bound a flaky-fail risk on the fast lane.Change
.is_ok()/.is_some()) — they still guard correctness on every run.Testing
cargo fmt --all -- --check✓cargo clippy --all-targets --all-features -- -D warnings✓🤖 Generated with Claude Code