fix(ci): scope release-please to pyproject.toml (stop bumping __init__.py sentinel)#82
Merged
Merged
Conversation
…py sentinel) The `python` release-type rewrote the PackageNotFoundError *fallback sentinel* in src/remo_cli/__init__.py (`__version__ = "0.0.0-dev"` -> the release version), mistaking it for the canonical literal. The real version comes from importlib.metadata (pyproject); the fallback must stay a dev sentinel or an un-installed source checkout would falsely report the last-released version. Switch to release-type `simple` with an explicit extra-files entry that bumps only `[project].version` in pyproject.toml. release-please now updates pyproject.toml + CHANGELOG.md + the manifest, and never touches __init__.py. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HAPB5GA4NVUgKFsVFVJDxN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first release PR (#81) showed the
pythonrelease-type rewriting the fallback sentinel insrc/remo_cli/__init__.py:That line is the "package not installed" sentinel — the real version comes from
importlib.metadata(per CLAUDE.md). Bumping it means an un-installed source checkout would falsely report the last-released version, and it'd drift on every release.Fix
Switch
release-type: python → simpleand add an explicitextra-filesentry so release-please bumps only[project].versioninpyproject.toml:release-please now updates
pyproject.toml+CHANGELOG.md+ the manifest, and never touches__init__.py. After this merges, release-please regenerates the open release PR (#81) with the corrected file set — all pre-merge and reviewable.🤖 Generated with Claude Code