Skip to content

Conversation

@Utkarshpandey0001
Copy link
Contributor

Fixes #1976

Added max-height and overflow-y-auto to AlertDialogContent component to enable scrolling when dialog content exceeds viewport height.

Fixes getAlby#1976

Added max-height and overflow-y-auto to AlertDialogContent component
to enable scrolling when dialog content exceeds viewport height.
@rolznz
Copy link
Contributor

rolznz commented Dec 15, 2025

Thanks for the PR! We try to avoid making changes to the core shadcn components, as each time they are updated we will get conflicts. Maybe this could be moved into one of our own components instead (in components, not components/ui) which simply passes the additional classnames to the shadcn component. Then we use our one instead. What do you think?

@Utkarshpandey0001
Copy link
Contributor Author

@rolznz sorry I was sick couldn't see the msg. You are right. I would say instead of making changes in shadcn component it's better to handle it in the same file where we are importing alertdialogue component. Let me test it once and I will back to you in few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: debug tools node command dialog has no scrollbar

2 participants