a11y: improve disabled and labeling support in ResponsiveButton #1992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Dec 23, 2025
| {...props} | ||
| variant={variant} | ||
| asChild={asChild} | ||
| disabled={disabled} |
Contributor
There was a problem hiding this comment.
I don't think we should add these additional props - they should be handled by shadcn (our component is just a wrapper for a shadcn button).
Author
There was a problem hiding this comment.
Thanks for the clarification, that makes sense 👍
I agree that accessibility semantics should live in the underlying shadcn Button rather than being duplicated in a wrapper component. Since ResponsiveButton is intentionally thin, adding extra props here could introduce inconsistencies over time.
I’m happy to:
revert the additional accessibility props in this PR, or
alternatively explore improvements directly in the shadcn button usage/config if that’s preferred.
Let me know which direction you’d like — thanks for the guidance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves accessibility semantics for
ResponsiveButton.aria-disabledis set when the button is disabledaria-hiddenThis keeps visual behavior unchanged while improving keyboard and
screen-reader support, especially when
asChildis used.