fix: record latency before ret/err events#2
Merged
pruthvikar merged 3 commits intomasterfrom Mar 16, 2026
Merged
Conversation
pruthvikar
force-pushed
the
fix/latency-before-events
branch
2 times, most recently
from
0842747 to
c5edd69
Compare
The latency field was recorded AFTER ret/err events fired, so the events' log output always showed latency as Empty. This broke the previous TraceLatency Drop-based approach where the timer dropped (recording latency) inside the block before events fired. Move latency_inst and latency_record into each mk_fut variant so that latency is recorded after the block completes but before any ret/err events emit their log lines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pruthvikar
force-pushed
the
fix/latency-before-events
branch
from
c5edd69 to
b1db5d6
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Box `matchers::BuildError` in closure to fix `result_large_err` - Use `self.cmp(other)` in `PartialOrd` impls for `MatchPattern` and `MatchDebug` to fix `non_canonical_partial_ord_impl` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
latencyspan field beforeret/errevents fire, not afterWhy
The
latencyflag was recording elapsed time on the span after ret/err events had already emitted their log lines. This meant those events always showedlatency = Empty— breaking Datadog log ingestion.The previous
TraceLatencyapproach usedDropon a local variable inside the async block, which naturally dropped before events fired. The fork's macro expansion moved recording to after the events, silently breaking the pipeline.How
Async case: Move
latency_instandlatency_recordinside eachmk_futvariant so latency records after#block.awaitcompletes but before ret/err events.Sync case: Split block evaluation from the match expression, inserting
latency_recordbetween them.Testing
cargo check -p tracing-attributespassesmakers clippy -p traits_derive)🤖 Generated with Claude Code