APP-951-New architecture for ditto #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sdks/kotlin/src/main/java/com/ditto/dittochat/DittoChat.kt # sdks/kotlin/src/main/java/com/ditto/dittochat/DittoChatModule.kt
Contributor
🟢 Test Coverage Report -
|
| Metric | Coverage | Status |
|---|---|---|
| 🟢 Lines | 93.78% | green |
| 🟢 Statements | 93.78% | green |
| 🟢 Functions | 95.83% | green |
| 🟢 Branches | 86.31% | green |
📊 View Detailed Coverage Report
ℹ️ Coverage Thresholds
- 🟢 Excellent (≥ 80%)
- 🟡 Good (60-79%)
- 🟠 Fair (40-59%)
- 🔴 Poor (< 40%)
Contributor
🟢 Test Coverage Report -
|
| Metric | Coverage | Status |
|---|---|---|
| 🟢 Lines | 92.53% | green |
| 🟢 Statements | 92.53% | green |
| 🟢 Functions | 90.56% | green |
| 🟢 Branches | 88.8% | green |
📊 View Detailed Coverage Report
ℹ️ Coverage Thresholds
- 🟢 Excellent (≥ 80%)
- 🟡 Good (60-79%)
- 🟠 Fair (40-59%)
- 🔴 Poor (< 40%)
Contributor
|
| Severity | Count |
|---|---|
| 🔴 Critical | 0 |
| 🟠 High | 0 |
| 🟡 Medium | 1 |
| 🔵 Low | 0 |
| Total | 1 |
📋 Vulnerability Details
- CVE-2025-64718 (MEDIUM) in
js-yaml:3.14.2- Description: js-yaml is a JavaScript YAML parser and dumper. In js-yaml 4.1.0 and below, it's possible for an attacker to modify the prototype of the result of a parsed yaml document via prototype pollution ( proto ). All users who parse untrusted yaml documents may be impacted. The problem is patched in js-yaml 4.1.1. Users can protect against this kind of attack on the server by using node --disable-proto=delete or deno (in Deno, pollution protection is on by default).
- CVSS: 5.3
ℹ️ How to fix vulnerabilities
- Update vulnerable dependencies to patched versions
- Run
npm audit fixornpm audit fix --force - Check for alternative packages if updates aren't available
- Review and update your
package.jsonandpackage-lock.json
ErikEverson
reviewed
Dec 11, 2025
| private val gson: Gson, | ||
| private val usersCollection: String, | ||
| private val chatRetentionPolicy: ChatRetentionPolicy | ||
| private val gson: Gson = Gson(), |
Collaborator
There was a problem hiding this comment.
do we want to be using GSON. I think we are using kotlin serialization for forge? Just a question not sure which is the right direction
Contributor
Author
There was a problem hiding this comment.
@shamari-ditto can confirm but I can make it to where we use w/e. This was just what we used historically. Not difficult to change.
Contributor
|
| Severity | Count |
|---|---|
| 🔴 Critical | 0 |
| 🟠 High | 0 |
| 🟡 Medium | 1 |
| 🔵 Low | 0 |
| Total | 1 |
📋 Vulnerability Details
- CVE-2025-64718 (MEDIUM) in
js-yaml:3.14.2- Description: js-yaml is a JavaScript YAML parser and dumper. In js-yaml 4.1.0 and below, it's possible for an attacker to modify the prototype of the result of a parsed yaml document via prototype pollution ( proto ). All users who parse untrusted yaml documents may be impacted. The problem is patched in js-yaml 4.1.1. Users can protect against this kind of attack on the server by using node --disable-proto=delete or deno (in Deno, pollution protection is on by default).
- CVSS: 5.3
ℹ️ How to fix vulnerabilities
- Update vulnerable dependencies to patched versions
- Run
npm audit fixornpm audit fix --force - Check for alternative packages if updates aren't available
- Review and update your
package.jsonandpackage-lock.json
…om:getditto/DittoChatPackage into feature/APP-951-New-Architecture-for-Ditto
Contributor
🟢 Test Coverage Report -
|
| Metric | Coverage | Status |
|---|---|---|
| 🟢 Lines | 87.35% | green |
| 🟢 Statements | 87.35% | green |
| 🟢 Functions | 92.45% | green |
| 🟢 Branches | 86.1% | green |
📊 View Detailed Coverage Report
ℹ️ Coverage Thresholds
- 🟢 Excellent (≥ 80%)
- 🟡 Good (60-79%)
- 🟠 Fair (40-59%)
- 🔴 Poor (< 40%)
Contributor
🟢 Test Coverage Report -
|
| Metric | Coverage | Status |
|---|---|---|
| 🟢 Lines | 92.05% | green |
| 🟢 Statements | 92.05% | green |
| 🟢 Functions | 85.98% | green |
| 🟢 Branches | 88.64% | green |
📊 View Detailed Coverage Report
ℹ️ Coverage Thresholds
- 🟢 Excellent (≥ 80%)
- 🟡 Good (60-79%)
- 🟠 Fair (40-59%)
- 🔴 Poor (< 40%)
Contributor
|
| Severity | Count |
|---|---|
| 🔴 Critical | 0 |
| 🟠 High | 0 |
| 🟡 Medium | 1 |
| 🔵 Low | 0 |
| Total | 1 |
📋 Vulnerability Details
- CVE-2025-64718 (MEDIUM) in
js-yaml:3.14.2- Description: js-yaml is a JavaScript YAML parser and dumper. In js-yaml 4.1.0 and below, it's possible for an attacker to modify the prototype of the result of a parsed yaml document via prototype pollution ( proto ). All users who parse untrusted yaml documents may be impacted. The problem is patched in js-yaml 4.1.1. Users can protect against this kind of attack on the server by using node --disable-proto=delete or deno (in Deno, pollution protection is on by default).
- CVSS: 5.3
ℹ️ How to fix vulnerabilities
- Update vulnerable dependencies to patched versions
- Run
npm audit fixornpm audit fix --forcein the root directory - Check for alternative packages if updates aren't available
- Review and update your
package.jsonandpackage-lock.json
Contributor
|
| Severity | Count |
|---|---|
| 🔴 Critical | 0 |
| 🟠 High | 0 |
| 🟡 Medium | 1 |
| 🔵 Low | 0 |
| Total | 1 |
📋 Vulnerability Details
- CVE-2025-64718 (MEDIUM) in
js-yaml:3.14.2- Description: js-yaml is a JavaScript YAML parser and dumper. In js-yaml 4.1.0 and below, it's possible for an attacker to modify the prototype of the result of a parsed yaml document via prototype pollution ( proto ). All users who parse untrusted yaml documents may be impacted. The problem is patched in js-yaml 4.1.1. Users can protect against this kind of attack on the server by using node --disable-proto=delete or deno (in Deno, pollution protection is on by default).
- CVSS: 5.3
ℹ️ How to fix vulnerabilities
- Update vulnerable dependencies to patched versions
- Run
npm audit fixornpm audit fix --forcein the root directory - Check for alternative packages if updates aren't available
- Review and update your
package.jsonandpackage-lock.json
ErikEverson
approved these changes
Dec 18, 2025
Collaborator
|
@bmalumphy Might just see if there are new version of some of the stuff in the web library so we can remove the CVE's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.