Skip to content

switch buckets#8615

Open
jay-418 wants to merge 3 commits intomainfrom
jay/s3
Open

switch buckets#8615
jay-418 wants to merge 3 commits intomainfrom
jay/s3

Conversation

@jay-418
Copy link
Copy Markdown
Contributor

@jay-418 jay-418 commented Apr 4, 2026

Prefer generic buckets.

solves https://github.com/getlantern/engineering/issues/3080

Warning

When this is merged, we must

Copilot AI review requested due to automatic review settings April 4, 2026 02:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI release tooling to use a more generic S3 URL format and improves Slack messaging for nightly builds by linking to the workflow run.

Changes:

  • Switch displayed S3 download URLs from virtual-hosted style (${bucket}.s3.amazonaws.com) to path-style (s3.amazonaws.com/${bucket}) in CI scripts.
  • Add WORKFLOW_URL support to Slack message formatting and use it for nightly announcements.
  • Change the release workflow to source BUCKET from secrets.S3_RELEASES_BUCKET and propagate WORKFLOW_URL.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
scripts/ci/publish-to-s3.sh Updates the printed S3 URLs after upload to use path-style URLs.
scripts/ci/format.sh Updates S3 URLs and adjusts Slack message formatting to use WORKFLOW_URL for nightly builds.
.github/workflows/release.yml Switches BUCKET to come from secrets and adds WORKFLOW_URL env wiring for Slack formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants