Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CI release tooling to use a more generic S3 URL format and improves Slack messaging for nightly builds by linking to the workflow run.
Changes:
- Switch displayed S3 download URLs from virtual-hosted style (
${bucket}.s3.amazonaws.com) to path-style (s3.amazonaws.com/${bucket}) in CI scripts. - Add
WORKFLOW_URLsupport to Slack message formatting and use it for nightly announcements. - Change the release workflow to source
BUCKETfromsecrets.S3_RELEASES_BUCKETand propagateWORKFLOW_URL.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/ci/publish-to-s3.sh | Updates the printed S3 URLs after upload to use path-style URLs. |
| scripts/ci/format.sh | Updates S3 URLs and adjusts Slack message formatting to use WORKFLOW_URL for nightly builds. |
| .github/workflows/release.yml | Switches BUCKET to come from secrets and adds WORKFLOW_URL env wiring for Slack formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer generic buckets.
solves https://github.com/getlantern/engineering/issues/3080
Warning
When this is merged, we must
S3_RELEASES_BUCKET=lantern.io