Fix tight-loop retry on H2 INTERNAL_ERROR in datacap stream reconnect#394
Merged
myleshorton merged 2 commits intomainfrom Apr 2, 2026
Merged
Fix tight-loop retry on H2 INTERNAL_ERROR in datacap stream reconnect#394myleshorton merged 2 commits intomainfrom
myleshorton merged 2 commits intomainfrom
Conversation
Auto-diagnosed from Freshdesk ticket #171798. Root cause: server sends RST_STREAM INTERNAL_ERROR on 60s timeout; client retried immediately with no backoff, causing error storm. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the DataCap SSE reconnect backoff reset threshold to prevent rapid reconnect loops when the server drops the stream around its timeout window.
Changes:
- Increased the backoff reset threshold from 30s to 90s in
DataCapStreamso connections that consistently die around ~60s don’t continuously reset backoff and reconnect immediately.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address PR review: replace magic 90s literal with a named constant and document why it must exceed the server's ~60s SSE idle timeout. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: backoff reset threshold was 30s, below server 60s timeout. Fix: raise to 90s. Auto-diagnosed from Freshdesk ticket 171798.