Skip to content

Version 0.25.0#667

Open
liuzicheng1987 wants to merge 1 commit into
mainfrom
f/v_0_25_0
Open

Version 0.25.0#667
liuzicheng1987 wants to merge 1 commit into
mainfrom
f/v_0_25_0

Conversation

@liuzicheng1987
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version to 0.25.0 and introduces support for Boost.Serialization and YAS backends. The changes primarily involve updating the CMake configuration to handle these new dependencies. Review feedback indicates that the conditional logic for including dependencies in reflectcpp-config.cmake.in should be refactored for better maintainability and to fix a missing check for the AVRO backend. Additionally, the reviewer pointed out that the new dependencies must be declared in the vcpkg.json and package.xml manifests to ensure proper dependency resolution and package management.

Comment thread reflectcpp-config.cmake.in
Comment thread vcpkg.json
Comment thread package.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant