Skip to content

Fix infinite recursion; fixes #677#678

Open
liuzicheng1987 wants to merge 6 commits into
mainfrom
f/schema_add_tags
Open

Fix infinite recursion; fixes #677#678
liuzicheng1987 wants to merge 6 commits into
mainfrom
f/schema_add_tags

Conversation

@liuzicheng1987
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors variant schema generation and field checking by replacing recursive template metaprogramming with fold expressions and variable templates, such as all_fields_v. It also modernizes namespace declarations and adds a new test case for JSON schema generation with tagged variants. The review feedback suggests improving all_fields_v to support empty template parameter packs and removing an unused parameter in FieldVariantParser::to_schema.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread include/rfl/internal/all_fields.hpp Outdated
Comment thread include/rfl/parsing/FieldVariantParser.hpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant