Skip to content

Conversation

@yoursdearboy
Copy link

Closes #1111

What has been done to verify that this works as intended?

Successfully started PostgreSQL container with docker-compose.dev.yml (make dev) and run migrations (cd server && make)

Why is this the best possible solution? Were any other approaches considered?

It synchronizes credentials across docker and server configs. Another approach would be to change credentials in server config or guide developers to change them manually.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Doesn't affect users.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant