docs(skill): Move dotagents skill to top-level and update content#37
Merged
docs(skill): Move dotagents skill to top-level and update content#37
Conversation
Move the dotagents skill from plugins/dotagents/skills/ to the top-level skills/ directory, symlinking back from the plugin structure. This keeps the source of truth at the repo level. Updates the skill content to reflect the current CLI: - Add mcp command to SKILL.md commands table - Add positional skill args and multi-skill support to add command - Add --skill alias alongside --name - Add list --json flag to cli-reference - Fix install --force description (lockfile bypass, not reinstall) - Expand source formats with GitHub SSH and HTTPS URLs - Add hooks to Key Concepts section - Document interactive prompt on wildcard remove - Add headers field to HTTP MCP example Agent transcript: https://claudescope.sentry.dev/share/w9kPvHx_axMCozPnoWsnsxdJHNQnaw1JFe1crylYCXw
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| @@ -0,0 +1 @@ | |||
| ../../../skills/dotagents No newline at end of file | |||
There was a problem hiding this comment.
Bug: The new symlink at plugins/dotagents/skills/dotagents will fail to create on standard Windows environments, causing CLI commands to crash due to permission errors.
Severity: HIGH
Suggested Fix
Implement platform-specific logic for creating symlinks. On Windows, check for permissions and consider falling back to creating a directory junction if creating a symlink fails. Add a Windows runner to the CI/CD pipeline to test this behavior.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: plugins/dotagents/skills/dotagents#L1
Potential issue: The code uses Node.js's `fs.symlink()` API to create a symlink at
`plugins/dotagents/skills/dotagents`. This API lacks cross-platform handling and has
known issues on Windows, where creating symlinks typically requires Administrator
privileges or Developer Mode. For Windows users without these permissions, CLI commands
like `dotagents init` or `dotagents sync` will attempt to create the symlink and fail
with an `EPERM` error, causing the command to crash. The CI pipeline only runs on Linux,
so this platform-specific issue was not caught during testing.
Did we get this right? 👍 / 👎 to inform future reviews.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the dotagents skill from
plugins/dotagents/skills/to the top-levelskills/directory and symlink it back from the plugin structure. This keeps the source of truth at the repo level rather than buried in the plugin tree.Also updates the skill content to match the current CLI after recent PRs (#34, #35, #36):
mcpcommand (was completely missing from commands table and cli-reference)addcommand--skillalias alongside--namelist --jsonflaginstall --forcedescription (it bypasses the lockfile, not reinstalls)removeheadersfield to HTTP MCP example in configuration referenceAgent transcript: https://claudescope.sentry.dev/share/wmsIuw4whFWDbrLlaEhCzBR9tSiCVLSnVawOUnPYyhw