Merged
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
cleptric
approved these changes
Mar 5, 2026
Lms24
commented
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #270, we introdued a changelog generation script that updates attributes' changelog entries. We missed an infinite recursion-like problem though where re-running this script would add #270 to the changelog of all attributes, because #270 added the changelog entries to all attribute JSON files. This would go on indefinitely 😅
This PR:
yarn generate. The reason is that I didn't think this through when suggesting that we run the script every on every PR. At this point in time, the script doesn't have a reliable way to determine the PR (said PR either doesn't exist yet, or wasn't merged).If anyone is blocked by the current state on
main, please feel free to merge this PR at any time :) I'll pick it up tomorrow morning VIE time otherwise.PR Checklist
yarn testand verified that the tests pass.yarn generate && yarn formatto generate and format code and docs.