Skip to content

fix: Avoid changelog generation recursion#274

Merged
Lms24 merged 2 commits intomainfrom
lms/fix-attr-changelog-recursion
Mar 5, 2026
Merged

fix: Avoid changelog generation recursion#274
Lms24 merged 2 commits intomainfrom
lms/fix-attr-changelog-recursion

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 4, 2026

Description

In #270, we introdued a changelog generation script that updates attributes' changelog entries. We missed an infinite recursion-like problem though where re-running this script would add #270 to the changelog of all attributes, because #270 added the changelog entries to all attribute JSON files. This would go on indefinitely 😅

This PR:

  • adds an ignore list of commit hashes and adds the commit hash of feat: Add changelog tracking to attribute definitions #270 to that list. Running the changelog script now, produces no changes to the existing JSON files.
  • removes the changelog generaction script invocation from yarn generate. The reason is that I didn't think this through when suggesting that we run the script every on every PR. At this point in time, the script doesn't have a reliable way to determine the PR (said PR either doesn't exist yet, or wasn't merged).
  • Adds a little progress indicator to the generation script since it takes quite long to go through all attributes.

If anyone is blocked by the current state on main, please feel free to merge this PR at any time :) I'll pick it up tomorrow morning VIE time otherwise.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate && yarn format to generate and format code and docs.

@Lms24 Lms24 requested review from a team, cleptric, lcian, mjq and nsdeschenes as code owners March 4, 2026 17:21
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (attributes) Add allow_any_value field to attribute schema by vgrozdanic in #272
  • (http) Add http.server.request.time_in_queue attribute by dingsdax in #267
  • (resource) Add resource.deployment.environment by mjq in #266
  • Add changelog tracking to attribute definitions by ericapisani in #270

Bug Fixes 🐛

  • (attributes) Remove allow_any_value boolean attribute and allow any as type by vgrozdanic in #273
  • (gen_ai) Input and output token description by obostjancic in #261
  • Avoid changelog generation recursion by Lms24 in #274

Documentation 📚

  • Update README with up-to-date links by ericapisani in #258

Internal Changes 🔧

Deps

  • Bump svgo from 3.3.2 to 3.3.3 by dependabot in #275
  • Bump svelte from 5.51.5 to 5.53.5 by dependabot in #271
  • Bump rollup from 4.40.1 to 4.59.0 by dependabot in #269
  • Bump svelte from 5.48.1 to 5.51.5 by dependabot in #260

Other

  • (ai) Deprecate rest of ai.* attributes by constantinius in #264
  • (deps-dev) Bump tar from 7.5.7 to 7.5.8 by dependabot in #259
  • (gen_ai) Deprecate gen_ai.tool.input, gen_ai.tool.message, gen_ai.tool.output by constantinius in #265

🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 requested a review from ericapisani March 4, 2026 17:26
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@Lms24 Lms24 self-assigned this Mar 5, 2026
@Lms24 Lms24 merged commit debe89d into main Mar 5, 2026
11 checks passed
@Lms24 Lms24 deleted the lms/fix-attr-changelog-recursion branch March 5, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants