feat(attributes): Add network connection-related attributes#279
Open
feat(attributes): Add network connection-related attributes#279
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds attributes sent from the JS SDK describing network connections. As we discussed in Slack, we want to take the opportunity to move the non-existing/suboptimal attribute names over to properly name-spaced attribute names.
connectionTypenetwork.connection.typeeffectiveConnectionTypenetwork.connection.effective_typeconnection.rttnetwork.connection.rttI checked an none of these attributes are used in dashboard prebuilt configs.
Worth noting: In contrast to the strict OTel definition of
network.connection.*attributes, the values sent from the browser SDKs are estimations and not actual values. I think this is generally fine as other SDKs can still send these attributes with the actual numbers. We also discussed this in slack and no-one had strong opinions. I'd err towards running with these attributes to avoid creating yet more custom attributes.PR Checklist
yarn testand verified that the tests pass.yarn generate && yarn formatto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)pii(i.e.maybeortrue. Usefalseonly for values that should never be scrubbed such as IDs)If an attribute was deprecated: