Skip to content

feat(attributes): Add device memory and core count attributes#281

Open
Lms24 wants to merge 1 commit intomainfrom
lms/feat-add-device-attributes
Open

feat(attributes): Add device memory and core count attributes#281
Lms24 wants to merge 1 commit intomainfrom
lms/feat-add-device-attributes

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 6, 2026

Description

This PR adds attributes sent from the JS SDK describing device memory and cpu core count properties. As we discussed in Slack, we want to take the opportunity to move the non-existing/suboptimal attribute names over to properly name-spaced attribute names.

Old attribute (deprecated) New attribute OTel equivalent
hardwareConcurrency device.cpu.logical_core_count device. exists but not the exact attribute
deviceMemory device.memory.estimated_capacity device. exists but not the exact attribute

I checked and none of these attributes are used in dashboard prebuilt configs.

Worth noting:

  • I went with device.memory.estimated_capacity because browsers really only give a rough "bucket" how much memory is available. They cap it at 8GB mostly. Also changed the expected type to integer since IMHO it makes more sense to query/aggregate on them. We can send gigabyte as the unit on the attribute.
  • The browser likely only returns a smaller than actually existing number of CPU cores (navigator.hardwareConcurrency). This is because browsers report what amount of logical cores they have at their disposal.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate && yarn format to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for pii (i.e. maybe or true. Use false only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add device memory and core count attributes by Lms24 in #281
  • Add allow_any_value field to attribute schema by vgrozdanic in #272

Other

  • (http) Add http.server.request.time_in_queue attribute by dingsdax in #267
  • (resource) Add resource.deployment.environment by mjq in #266
  • Add sentry.timestamp.sequence attribute to the spec by logaretm in #262
  • Add changelog tracking to attribute definitions by ericapisani in #270

Bug Fixes 🐛

  • (attributes) Remove allow_any_value boolean attribute and allow any as type by vgrozdanic in #273
  • (gen_ai) Input and output token description by obostjancic in #261
  • Don't run changelog generation on yarn generate by Lms24 in #277
  • Avoid changelog generation recursion by Lms24 in #274

Documentation 📚

  • Update README with up-to-date links by ericapisani in #258

Internal Changes 🔧

Deps

  • Bump dompurify from 3.3.1 to 3.3.2 by dependabot in #278
  • Bump svgo from 3.3.2 to 3.3.3 by dependabot in #275
  • Bump svelte from 5.51.5 to 5.53.5 by dependabot in #271
  • Bump rollup from 4.40.1 to 4.59.0 by dependabot in #269
  • Bump svelte from 5.48.1 to 5.51.5 by dependabot in #260

Deps Dev

  • Bump tar from 7.5.8 to 7.5.10 by dependabot in #276
  • Bump tar from 7.5.7 to 7.5.8 by dependabot in #259

Other

  • (ai) Deprecate rest of ai.* attributes by constantinius in #264
  • (gen_ai) Deprecate gen_ai.tool.input, gen_ai.tool.message, gen_ai.tool.output by constantinius in #265

🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 self-assigned this Mar 6, 2026
@Lms24 Lms24 marked this pull request as ready for review March 6, 2026 11:59
@Lms24 Lms24 requested review from a team, cleptric, lcian, mjq and nsdeschenes as code owners March 6, 2026 11:59
@Lms24 Lms24 changed the title feat(attributes): Add old (deprecated) and new device memory and core count attributes feat(attributes): Add device memory and core count attributes Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant