Skip to content

fix: Log Warning instead of Error when ratelimited#4927

Open
bitsandfoxes wants to merge 3 commits intomainfrom
fix/rate-limiting-log-level
Open

fix: Log Warning instead of Error when ratelimited#4927
bitsandfoxes wants to merge 3 commits intomainfrom
fix/rate-limiting-log-level

Conversation

@bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Feb 16, 2026

Surfaced through getsentry/sentry-unity#2538

This PR addresses an inconsistency in expected, recoverable behaviour that has - as per log message - no effect on the user's application. Same as dropping events with too large attachments.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Fixes 🐛

  • fix: Log Warning instead of Error when ratelimited by bitsandfoxes in #4927

Dependencies ⬆️

Deps

  • Apps built using the Sentry SDK for .NET must now target iOS version 15 or higher. Previously only version 13 or higher was required. (#4781) by github-actions in #4781
  • Bump Cocoa SDK from v8.57.3 to v9.2.0 (#4781) by github-actions in #4781
  • chore(deps): update Native SDK to v0.12.7 by github-actions in #4920

Other

  • test(android): Use volatile to produce SIGSEGV in native crash test by jpnurmi in #4919

🤖 This preview updates automatically when you update the PR.

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.88%. Comparing base (7c80a90) to head (d31988a).

Files with missing lines Patch % Lines
src/Sentry/Http/HttpTransportBase.cs 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4927      +/-   ##
==========================================
+ Coverage   73.86%   73.88%   +0.01%     
==========================================
  Files         496      496              
  Lines       17927    17947      +20     
  Branches     3511     3516       +5     
==========================================
+ Hits        13242    13260      +18     
- Misses       3824     3825       +1     
- Partials      861      862       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell
Copy link
Collaborator

Is this consistent with what the other SDKs do for 429 response codes?

Arguably the user's tests could use mocks rather than a real Sentry instance... so I'm not sure if we want to change the SDK here to make one user's tests pass.

@bitsandfoxes
Copy link
Contributor Author

bitsandfoxes commented Feb 17, 2026

change the SDK here to make one user's tests pass

This is a red herring. It's not about user tests, they are just surfacing an inconsistency. The other SDKs are also all over the place, checking a few: Python and Dart logs a warning, Cocoa debug, Java does it like .NET right now, warns on dropped attachments and errors on 429.

My argument is still: If this is handled and expected behaviour, why is this an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants