fix: Log Warning instead of Error when ratelimited#4927
fix: Log Warning instead of Error when ratelimited#4927bitsandfoxes wants to merge 3 commits intomainfrom
Warning instead of Error when ratelimited#4927Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Fixes 🐛
Dependencies ⬆️Deps
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4927 +/- ##
==========================================
+ Coverage 73.86% 73.88% +0.01%
==========================================
Files 496 496
Lines 17927 17947 +20
Branches 3511 3516 +5
==========================================
+ Hits 13242 13260 +18
- Misses 3824 3825 +1
- Partials 861 862 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is this consistent with what the other SDKs do for 429 response codes? Arguably the user's tests could use mocks rather than a real Sentry instance... so I'm not sure if we want to change the SDK here to make one user's tests pass. |
This is a red herring. It's not about user tests, they are just surfacing an inconsistency. The other SDKs are also all over the place, checking a few: Python and Dart logs a My argument is still: If this is handled and expected behaviour, why is this an error. |
Surfaced through getsentry/sentry-unity#2538
This PR addresses an inconsistency in expected, recoverable behaviour that has - as per log message - no effect on the user's application. Same as dropping events with too large attachments.