-
Notifications
You must be signed in to change notification settings - Fork 242
feat: Add Spotlight integration for local development debugging #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DAcodedBEAT
wants to merge
2
commits into
getsentry:master
Choose a base branch
from
DAcodedBEAT:feature/spotlight
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+376
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| // This is an example program that demonstrates Sentry Go SDK integration | ||
| // with Spotlight for local development debugging. | ||
| // | ||
| // Try it by running: | ||
| // | ||
| // go run main.go | ||
| // | ||
| // To actually report events to Sentry, set the DSN either by editing the | ||
| // appropriate line below or setting the environment variable SENTRY_DSN to | ||
| // match the DSN of your Sentry project. | ||
| // | ||
| // Before running this example, make sure Spotlight is running: | ||
| // | ||
| // npm install -g @spotlightjs/spotlight | ||
| // spotlight | ||
| // | ||
| // Then open http://localhost:8969 in your browser to see the Spotlight UI. | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "log" | ||
| "time" | ||
|
|
||
| "github.com/getsentry/sentry-go" | ||
| ) | ||
|
|
||
| func main() { | ||
| err := sentry.Init(sentry.ClientOptions{ | ||
| // Either set your DSN here or set the SENTRY_DSN environment variable. | ||
| Dsn: "", | ||
| // Enable printing of SDK debug messages. | ||
| // Useful when getting started or trying to figure something out. | ||
| Debug: true, | ||
| // Enable Spotlight for local debugging. | ||
| Spotlight: true, | ||
| // Enable tracing to see performance data in Spotlight. | ||
| EnableTracing: true, | ||
| TracesSampleRate: 1.0, | ||
| }) | ||
| if err != nil { | ||
| log.Fatalf("sentry.Init: %s", err) | ||
| } | ||
| // Flush buffered events before the program terminates. | ||
| // Set the timeout to the maximum duration the program can afford to wait. | ||
| defer sentry.Flush(2 * time.Second) | ||
|
|
||
| log.Println("Sending sample events to Spotlight...") | ||
|
|
||
| // Capture a simple message | ||
| sentry.CaptureMessage("Hello from Spotlight!") | ||
|
|
||
| // Capture an exception | ||
| sentry.CaptureException(errors.New("example error for Spotlight debugging")) | ||
|
|
||
| // Capture an event with additional context | ||
| sentry.WithScope(func(scope *sentry.Scope) { | ||
| scope.SetTag("environment", "development") | ||
| scope.SetLevel(sentry.LevelWarning) | ||
| scope.SetContext("example", map[string]interface{}{ | ||
| "feature": "spotlight_integration", | ||
| "version": "1.0.0", | ||
| }) | ||
| sentry.CaptureMessage("Event with additional context") | ||
| }) | ||
|
|
||
| // Performance monitoring example | ||
| span := sentry.StartSpan(context.Background(), "example.operation") | ||
| defer span.Finish() | ||
|
|
||
| span.SetData("example", "data") | ||
| childSpan := span.StartChild("child.operation") | ||
| // Simulate some work | ||
| time.Sleep(100 * time.Millisecond) | ||
| childSpan.Finish() | ||
|
|
||
| log.Println("Events sent! Check your Spotlight UI at http://localhost:8969") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| package sentry | ||
|
|
||
| import ( | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| func TestSpotlightTransport(t *testing.T) { | ||
| // Mock Spotlight server | ||
| server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if r.Method != "POST" { | ||
| t.Errorf("Expected POST, got %s", r.Method) | ||
| } | ||
| if r.URL.Path != "/stream" { | ||
| t.Errorf("Expected /stream, got %s", r.URL.Path) | ||
| } | ||
| if ct := r.Header.Get("Content-Type"); ct != "application/x-sentry-envelope" { | ||
| t.Errorf("Expected application/x-sentry-envelope, got %s", ct) | ||
| } | ||
| if ua := r.Header.Get("User-Agent"); ua != "sentry-go/"+SDKVersion { | ||
| t.Errorf("Expected sentry-go/%s, got %s", SDKVersion, ua) | ||
| } | ||
| w.WriteHeader(http.StatusOK) | ||
| })) | ||
| defer server.Close() | ||
|
|
||
| mock := &MockTransport{} | ||
| st := NewSpotlightTransport(mock) | ||
| st.Configure(ClientOptions{SpotlightURL: server.URL + "/stream"}) | ||
|
|
||
| event := NewEvent() | ||
| event.Sdk.Name = "sentry-go" | ||
| event.Sdk.Version = SDKVersion | ||
| event.Message = "Test message" | ||
| st.SendEvent(event) | ||
|
|
||
| time.Sleep(100 * time.Millisecond) | ||
|
|
||
| if len(mock.Events()) != 1 { | ||
| t.Errorf("Expected 1 event, got %d", len(mock.Events())) | ||
| } | ||
| if mock.Events()[0].Message != "Test message" { | ||
| t.Errorf("Expected 'Test message', got %s", mock.Events()[0].Message) | ||
| } | ||
|
|
||
| if !st.Flush(time.Second) { | ||
| t.Errorf("Expected Flush to succeed") | ||
| } | ||
| } | ||
|
|
||
| func TestSpotlightTransportWithNoopUnderlying(_ *testing.T) { | ||
| // Mock Spotlight server | ||
| server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { | ||
| w.WriteHeader(http.StatusOK) | ||
| })) | ||
| defer server.Close() | ||
|
|
||
| st := NewSpotlightTransport(noopTransport{}) | ||
| st.Configure(ClientOptions{SpotlightURL: server.URL + "/stream"}) | ||
|
|
||
| event := NewEvent() | ||
| event.Message = "Test message" | ||
| st.SendEvent(event) | ||
| } | ||
|
|
||
| func TestSpotlightClientOptions(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| options ClientOptions | ||
| envVar string | ||
| wantErr bool | ||
| hasSpotlight bool | ||
| }{ | ||
| { | ||
| name: "Spotlight enabled with DSN", | ||
| options: ClientOptions{ | ||
| Dsn: "https://user@sentry.io/123", | ||
| Spotlight: true, | ||
| }, | ||
| hasSpotlight: true, | ||
| }, | ||
| { | ||
| name: "Spotlight enabled without DSN", | ||
| options: ClientOptions{ | ||
| Spotlight: true, | ||
| }, | ||
| hasSpotlight: true, | ||
| }, | ||
| { | ||
| name: "Spotlight disabled", | ||
| options: ClientOptions{ | ||
| Dsn: "https://user@sentry.io/123", | ||
| }, | ||
| hasSpotlight: false, | ||
| }, | ||
| { | ||
| name: "Spotlight with custom URL", | ||
| options: ClientOptions{ | ||
| Spotlight: true, | ||
| SpotlightURL: "http://custom:9000/events", | ||
| }, | ||
| hasSpotlight: true, | ||
| }, | ||
| { | ||
| name: "Spotlight enabled via env var", | ||
| options: ClientOptions{ | ||
| Dsn: "https://user@sentry.io/123", | ||
| }, | ||
| envVar: "true", | ||
| hasSpotlight: true, | ||
| }, | ||
| { | ||
| name: "Spotlight enabled via env var (numeric)", | ||
| options: ClientOptions{ | ||
| Dsn: "https://user@sentry.io/123", | ||
| }, | ||
| envVar: "1", | ||
| hasSpotlight: true, | ||
| }, | ||
| { | ||
| name: "Spotlight disabled via env var", | ||
| options: ClientOptions{ | ||
| Dsn: "https://user@sentry.io/123", | ||
| }, | ||
| envVar: "false", | ||
| hasSpotlight: false, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| if tt.envVar != "" { | ||
| t.Setenv("SENTRY_SPOTLIGHT", tt.envVar) | ||
| } | ||
|
|
||
| client, err := NewClient(tt.options) | ||
| if (err != nil) != tt.wantErr { | ||
| t.Errorf("NewClient() error = %v, wantErr %v", err, tt.wantErr) | ||
| return | ||
| } | ||
|
|
||
| if err != nil { | ||
| return | ||
| } | ||
|
|
||
| _, isSpotlight := client.Transport.(*SpotlightTransport) | ||
| if isSpotlight != tt.hasSpotlight { | ||
| t.Errorf("Expected SpotlightTransport = %v, got %v", tt.hasSpotlight, isSpotlight) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we can extend this test to verify that the underlying transport actually flushes and sends the events as well, so that it guards against breaking it.