Skip to content

Commit b2716ec

Browse files
committed
fix(ci): Remove global Spotlight env vars from E2E tests
Spotlight env vars (VITE_SENTRY_SPOTLIGHT, NEXT_PUBLIC_SENTRY_SPOTLIGHT) should only be set for tests that specifically test Spotlight functionality. Setting them globally was causing other tests to potentially behave differently (e.g., adding Spotlight integration, making extra network requests). The nextjs-15-spotlight test already has NEXT_PUBLIC_SENTRY_SPOTLIGHT set in its next.config.js, so it will continue to work.
1 parent b9d3337 commit b2716ec

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -928,9 +928,8 @@ jobs:
928928
PUBLIC_E2E_TEST_DSN: 'https://username@domain/123'
929929
REACT_APP_E2E_TEST_DSN: 'https://username@domain/123'
930930
VITE_E2E_TEST_DSN: 'https://username@domain/123'
931-
# For Spotlight environment variable tests
932-
VITE_SENTRY_SPOTLIGHT: 'true'
933-
NEXT_PUBLIC_SENTRY_SPOTLIGHT: 'true'
931+
# Note: Spotlight env vars are NOT set globally - they should only be set
932+
# in test apps that specifically test Spotlight functionality
934933
E2E_TEST_SENTRY_ORG_SLUG: 'sentry-javascript-sdks'
935934
E2E_TEST_SENTRY_PROJECT: 'sentry-javascript-e2e-tests'
936935
strategy:
@@ -1065,9 +1064,8 @@ jobs:
10651064
PUBLIC_E2E_TEST_DSN: ${{ secrets.E2E_TEST_DSN }}
10661065
REACT_APP_E2E_TEST_DSN: ${{ secrets.E2E_TEST_DSN }}
10671066
VITE_E2E_TEST_DSN: ${{ secrets.E2E_TEST_DSN }}
1068-
# For Spotlight environment variable tests
1069-
VITE_SENTRY_SPOTLIGHT: 'true'
1070-
NEXT_PUBLIC_SENTRY_SPOTLIGHT: 'true'
1067+
# Note: Spotlight env vars are NOT set globally - they should only be set
1068+
# in test apps that specifically test Spotlight functionality
10711069
E2E_TEST_SENTRY_ORG_SLUG: 'sentry-javascript-sdks'
10721070
E2E_TEST_SENTRY_PROJECT: 'sentry-javascript-e2e-tests'
10731071
strategy:

0 commit comments

Comments
 (0)