-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[WIP] feat: Span Streaming POC #17852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
31db546 to
20590fe
Compare
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
84ec3fe to
4c1a555
Compare
dc5f6de to
a2aec25
Compare
7bb62f4 to
fd533f3
Compare
a35edc7 to
2d9b938
Compare
e8e3944 to
2049208
Compare
2049208 to
860265a
Compare
860265a to
41c93ff
Compare
23c46cd to
25b73c6
Compare
66b37be to
282eed0
Compare
| } | ||
|
|
||
| expect(pageloadSpan!.attributes?.['ui.web_vital.ttfb.requestTime']).toEqual({ | ||
| type: expect.stringMatching(/^integer|double$/), |
Check failure
Code scanning / CodeQL
Missing regular expression anchor High test
Misleading operator precedence. The subexpression '^integer' is anchored at the beginning, but the other parts of this regular expression are not
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 8 hours ago
To fix this problem, the regular expression should be modified to match exactly either "integer" or "double," i.e., the string should be anchored at both the start (^) and end ($). The correct regular expression is /^(integer|double)$/, which matches only the whole string "integer" or "double" and nothing else. This change should be made on line 30 of the file dev-packages/browser-integration-tests/suites/span-first/web-vitals/web-vitals-ttfb/test.ts inside the expect.stringMatching argument. No additional imports or changes are required.
-
Copy modified line R30
| @@ -27,7 +27,7 @@ | ||
| } | ||
|
|
||
| expect(pageloadSpan!.attributes?.['ui.web_vital.ttfb.requestTime']).toEqual({ | ||
| type: expect.stringMatching(/^integer|double$/), | ||
| type: expect.stringMatching(/^(integer|double)$/), | ||
| value: expect.any(Number), | ||
| }); | ||
| }); |
This PR contains the POC span streaming implementation for browser SDKs.
Can be tested on
@sentry/browser@10.21.0-alpha.1and any higher-level SDKs.To opt into span streaming, set:
Also note that spans will no longer be sent to any event processors added via one if the
*.addEventProcessorAPIs. If you have any event processors, consider usingbeforeSendSpanorignoreSpans.