Skip to content

test(nuxt): Relax captured unhandled error assertion #18397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
logaretm merged 2 commits into from
Dec 4, 2025
Merged

test(nuxt): Relax captured unhandled error assertion #18397

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95716ed
test(nuxt): relax captured error assertion
logaretm Dec 3, 2025
e27cb50
ref: don't relax it too much
logaretm Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dev-packages/e2e-tests/test-applications/nuxt-3/tests/middleware.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,11 @@ test.describe('Server Middleware Instrumentation', () => {
type: 'Error',
mechanism: expect.objectContaining({
handled: false,
type: 'auto.middleware.nuxt',
// Type changes depending on whether it is being wrapped by Nitro or not
// This is a timing problem, sometimes Nitro can capture the error first, and sometimes it can't
// If nitro captures the error first, the type will be 'chained'
// If Sentry captures the error first, the type will be 'auto.middleware.nuxt'
// type: 'auto.middleware.nuxt',
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment explains that the mechanism type changes based on race conditions, but the assertion no longer validates the mechanism type at all. Consider asserting that the type is either 'auto.middleware.nuxt' or 'chained' to maintain some test coverage:

type: expect.stringMatching(/^(auto\.middleware\.nuxt|chained)$/),

This would document the expected behavior while handling the race condition.

Copilot uses AI. Check for mistakes.
}),
}),
);
Expand Down