-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: upgrade Playwright to ~1.56.0 for WSL2 compatibility #18468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
96c44c8
4ef64df
d80144f
897c971
b94dddb
ed53947
e7ed9d9
97fb766
bf41f68
b440e7c
ab1821c
623b002
8c79ac6
8180bfa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,10 @@ test.describe('server-side errors', () => { | |
| return transactionEvent.transaction === 'GET /ssr-error'; | ||
| }); | ||
|
|
||
| await page.goto('/ssr-error'); | ||
| // This page returns an error status code, so we need to catch the navigation error | ||
| await page.goto('/ssr-error').catch(() => { | ||
| // Expected to fail with net::ERR_HTTP_RESPONSE_CODE_FAILURE in newer Chromium versions | ||
| }); | ||
|
|
||
|
Comment on lines
+14
to
18
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. q: does playwright throw for requests with errors now?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a Chromium behavior change in version 141 (bundled with Playwright 1.56). When navigating to a page that returns an HTTP error status code (4xx/5xx), Chromium now throws This affects tests that intentionally navigate to error pages. The workaround is to catch the navigation error since we're testing the error handling behavior, not the navigation itself. You can also use
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks for explaining. |
||
| const errorEvent = await errorEventPromise; | ||
| const transactionEvent = await transactionEventPromise; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.