ref(core): Add @sentry/conventions to @sentry/core and align versions#21855
Open
Lms24 wants to merge 5 commits into
Open
ref(core): Add @sentry/conventions to @sentry/core and align versions#21855Lms24 wants to merge 5 commits into
@sentry/conventions to @sentry/core and align versions#21855Lms24 wants to merge 5 commits into
Conversation
Lms24
requested review from
JPeer264,
andreiborza,
chargome,
mydea and
nicohrubec
and removed request for
a team
andreiborza
reviewed
Jun 30, 2026
| @@ -138,7 +139,7 @@ export function getDynamicSamplingContextFromSpan(span: Span): Readonly<Partial< | |||
|
|
|||
| // We don't want to have a transaction name in the DSC if the source is "url" because URLs might contain PII | |||
| // TODO(v11): Only read `SEMANTIC_ATTRIBUTE_SENTRY_SOURCE` again, once we renamed it to `sentry.span.source` | |||
Member
Author
There was a problem hiding this comment.
This sounded really confusing, thanks for calling it out! I reworded it. We'll need to remove SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, so the comment should reflect it
Contributor
size-limit report 📦
|
nicohrubec
approved these changes
Jun 30, 2026
andreiborza
approved these changes
Jun 30, 2026
chargome
approved these changes
Jun 30, 2026
chargome
reviewed
Jun 30, 2026
| preset: 'es2015', | ||
| }, | ||
|
|
||
| hoistTransitiveImports: false, |
Member
Author
There was a problem hiding this comment.
argh no, this shouldn't be part of the PR. My mistake. Thanks for flagging!
Lms24
force-pushed
the
lms/ref-deps-sentry-conventions-in-core
branch
from
3f1b5ba to
b6640bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
@sentry/conventionspackage to core and bumps it everywhere to the latest 0.13.0 version (minimum, still caret-ranged) for consistency. To make use of the new dependency, this also replaces thesentry.span.sourceconstant with the new convention-based export.We should replace our usage of our own
semanticAttributes.tsexport over time but I'd prefer doing this in follow-up PRs, case-by-case since this will change a lot of files for each attribute.ref #18895