Skip to content

chore(opentelemetry): Add worker as export | sort exports #21859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JPeer264 wants to merge 2 commits into
base: develop
Choose a base branch
from
+14 −23
Open

chore(opentelemetry): Add worker as export | sort exports #21859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
376aeda
chore(opentelemetry): Add worker as export | sort exports
JPeer264 Jun 30, 2026
b7ab468
fixup! chore(opentelemetry): Add worker as export | sort exports
JPeer264 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 14 additions & 23 deletions packages/opentelemetry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,30 +18,21 @@
"exports": {
"./package.json": "./package.json",
".": {
"import": {
"node": {
"types": "./build/types/index.d.ts",
"default": "./build/esm/index.js"
},
"browser": {
"types": "./build/types/index.d.ts",
"default": "./build/esm/index.browser.js"
},
"types": "./build/types/index.d.ts",
"default": "./build/esm/index.js"
"types": "./build/types/index.d.ts",

@sentry sentry Bot Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The single types field in package.json provides Node.js types to browser environments, causing a type-runtime mismatch and leading to runtime errors.
Severity: HIGH

Suggested Fix

Revert the package.json exports to use per-environment types fields. Each conditional export (e.g., for browser and node) should have its own types entry pointing to the correct type definition file for that specific environment. This will likely require generating separate type definitions for the browser entrypoint.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: packages/opentelemetry/package.json#L21

Potential issue: The `package.json` `exports` map was updated to use a single, top-level
`types` field. This field points to type definitions generated exclusively from the
Node.js entrypoint (`src/index.ts`). However, the package also provides a separate
browser-specific entrypoint (`src/index.browser.ts`) with different exports and
implementations. This creates a type-runtime mismatch for users in a browser
environment. TypeScript will indicate that Node-specific exports, like the full
`SentryAsyncLocalStorageContextManager` class, are available. At runtime, the
browser-specific stub implementation is used, which lacks the methods of the Node
version, leading to runtime errors like "method is not a function".

@JPeer264 JPeer264 Jul 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only types file we have

@JPeer264 JPeer264 Jul 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in general not a bad comment

"node": {
"import": "./build/esm/index.js",
"require": "./build/cjs/index.js"
},
"require": {
"node": {
"types": "./build/types/index.d.ts",
"default": "./build/cjs/index.js"
},
"browser": {
"types": "./build/types/index.d.ts",
"default": "./build/cjs/index.browser.js"
},
"types": "./build/types/index.d.ts",
"default": "./build/cjs/index.js"
}
"worker": {
"import": "./build/esm/index.js",
"require": "./build/cjs/index.js"
},
"browser": {
"import": "./build/esm/index.browser.js",
"require": "./build/cjs/index.browser.js"
Comment on lines +22 to +32

@sentry sentry Bot Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The exports order in package.json is incorrect. Generic import/require conditions appear before the browser condition, causing bundlers to select the Node.js build for browser environments.
Severity: HIGH

Suggested Fix

Reorder the exports conditions in package.json to place specific environment conditions (browser, worker, node) before the generic import and require fallbacks. This ensures that environment-specific bundlers select the correct entry point. For example, the browser condition should be evaluated before the top-level import condition.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: packages/opentelemetry/package.json#L21-L34

Potential issue: The `exports` map in `package.json` has an incorrect condition order.
Generic conditions `import` and `require` are listed before specific environment
conditions like `browser`. According to Node.js resolution rules, the first matching
condition is used. This means browser bundlers will match the generic `import` condition
and receive the Node.js-specific build (`./build/esm/index.js`). This build imports
`node:async_hooks`, which is not available in browsers, leading to runtime errors. The
intended browser-specific build, which provides a safe stub for Node.js APIs, will be
ignored.

Did we get this right? 👍 / 👎 to inform future reviews.

@JPeer264 JPeer264 Jul 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. Didn't know that matters

},
"import": "./build/esm/index.js",
"require": "./build/cjs/index.js"
}
},
"typesVersions": {
Expand Down
Loading