fix(browser): Flush telemetry when page is hidden#21862
Draft
Lms24 wants to merge 1 commit into
Draft
Conversation
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, we only flushed logs, metrics and client reports when the page is hidden (
visibilitychange: hidden). This PR generalizes the flushing behaviour to callclient.flush(), which in turn flushes all our telemetry. Specifically, errors and spans which previously were unaffected. Logs and metrics will still be flushed because they already listen toclient.on('flush'), similarly to the span buffer. I think think this should be a fair change and reduces some bundle size on top :)Came up while investigating partially sent traces when span streaming is enabled (e.g. child spans already sent but no
pageloadspan).ref #21805