Skip to content

test(google-genai): Move google-genai integration tests to use a real client#21909

Merged
nicohrubec merged 1 commit into
developfrom
nh/google-genai-real-sdk
Jul 2, 2026
Merged

test(google-genai): Move google-genai integration tests to use a real client#21909
nicohrubec merged 1 commit into
developfrom
nh/google-genai-real-sdk

Conversation

@nicohrubec

@nicohrubec nicohrubec commented Jul 2, 2026

Copy link
Copy Markdown
Member

similar to #21906

Using a real client should generally be more useful as this is what we instrument and also allows us to reuse the integration suites for our orchestrion ports since orchestrion injects the channels only in the real client.

Replaces the hand-written MockGoogleGenerativeAI classes in the truncation and
system-instructions scenarios with the real @google/genai SDK driven by an
express mock server, matching the rest of the suite. The auto integration
already wraps clients via the same instrumentGoogleGenAIClient the fakes used,
so dropping the manual wrap is behavior-preserving. Adds the express-server
transaction filter to instrument-no-truncation.mjs (the fakes made no HTTP
calls, so it wasn't needed before).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nicohrubec nicohrubec changed the title test(google-genai): Port fake scenarios to the real SDK test(google-genai): Move google-genai integration tests to use a real client Jul 2, 2026
@nicohrubec nicohrubec marked this pull request as ready for review July 2, 2026 06:54
@nicohrubec nicohrubec requested a review from a team as a code owner July 2, 2026 06:54
@nicohrubec nicohrubec requested review from JPeer264, andreiborza and mydea and removed request for a team July 2, 2026 06:54
@nicohrubec nicohrubec merged commit d2aa8ae into develop Jul 2, 2026
52 checks passed
@nicohrubec nicohrubec deleted the nh/google-genai-real-sdk branch July 2, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants