Skip to content

ref(huggingface-hub): Remove set_data_normalized for the gen_ai.response.finish_reasons attribute #5507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexander-alderman-webb wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −6
Draft

ref(huggingface-hub): Remove set_data_normalized for the gen_ai.response.finish_reasons attribute #5507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions sentry_sdk/integrations/huggingface_hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,7 @@ def new_huggingface_task(*args: "Any", **kwargs: "Any") -> "Any":
span.set_data(SPANDATA.GEN_AI_RESPONSE_MODEL, response_model)

if finish_reason is not None:
set_data_normalized(
span,
Copy link

@cursor cursor bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-serializable finish reason stored

High Severity

Replacing set_data_normalized with span.set_data for SPANDATA.GEN_AI_RESPONSE_FINISH_REASONS can store non-primitive finish_reason values (e.g., enums/objects/lists) without normalization, which can break span/event serialization or change the expected stored type for gen_ai.response.finish_reasons.

Additional Locations (2)

Fix in Cursor Fix in Web

Copy link
Contributor Author

@alexander-alderman-webb alexander-alderman-webb Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the types here they look to be str or None:

https://github.com/search?q=repo%3Ahuggingface%2Fhuggingface_hub+finish_reason%3A+&type=code

span.set_data(
SPANDATA.GEN_AI_RESPONSE_FINISH_REASONS,
finish_reason,
)
Expand Down Expand Up @@ -258,8 +257,7 @@ def new_details_iterator() -> "Iterable[Any]":
yield chunk

if finish_reason is not None:
set_data_normalized(
span,
span.set_data(
SPANDATA.GEN_AI_RESPONSE_FINISH_REASONS,
finish_reason,
)
Expand Down Expand Up @@ -337,8 +335,7 @@ def new_iterator() -> "Iterable[str]":
)

if finish_reason is not None:
set_data_normalized(
span,
span.set_data(
SPANDATA.GEN_AI_RESPONSE_FINISH_REASONS,
finish_reason,
)
Expand Down
Loading