Skip to content

ref(pydantic-ai): Remove set_data_normalized for the gen_ai.response.model attribute #5512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexander-alderman-webb wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

ref(pydantic-ai): Remove set_data_normalized for the gen_ai.response.model attribute #5512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentry_sdk/integrations/pydantic_ai/spans/ai_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@
if not response:
return

set_data_normalized(span, SPANDATA.GEN_AI_RESPONSE_MODEL, response.model_name)
span.set_data(SPANDATA.GEN_AI_RESPONSE_MODEL, response.model_name)

Check warning on line 210 in sentry_sdk/integrations/pydantic_ai/spans/ai_client.py

View workflow job for this annotation

GitHub Actions / warden: find-bugs

Missing attribute check for response.model_name causes unhandled AttributeError 

Line 210 accesses `response.model_name` without checking if the attribute exists, and it's outside the try-except block. If the response object doesn't have a `model_name` attribute, this will raise an unhandled `AttributeError` that propagates to the caller. The similar code in `invoke_agent.py` (line 168) correctly uses `if hasattr(response, "model_name") and response.model_name:` before accessing the attribute.
try:
# Extract text from ModelResponse
if hasattr(response, "parts"):
Expand Down
Loading