fix(pydantic-ai): Adapt to missing ToolManager._call_tool#5522
Open
sentrivana wants to merge 7 commits intomasterfrom
Open
fix(pydantic-ai): Adapt to missing ToolManager._call_tool#5522sentrivana wants to merge 7 commits intomasterfrom
ToolManager._call_tool#5522sentrivana wants to merge 7 commits intomasterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛Openai
Other
Documentation 📚
Internal Changes 🔧Agents
Openai Agents
Other
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| elif hasattr(ToolManager, "_call_tool"): | ||
| # older versions | ||
| _patch_call_tool() | ||
|
|
There was a problem hiding this comment.
Wrong patch chosen when both methods exist
Medium Severity
_patch_tool_execution prioritizes patching ToolManager.execute_tool_call whenever it exists, even if ToolManager._call_tool also exists. In any pydantic-ai version where _call_tool remains the actual execution choke point, this can silently skip instrumentation (no execute_tool_span) or change which layer is wrapped.
Contributor
Author
There was a problem hiding this comment.
We prefer execute_tool_call because it's the new way of doing things, and only fall back to the old way (_call_tool) if not possible.
|
|
||
| ToolManager.execute_tool_call = wrapped_execute_tool_call | ||
|
|
||
|
|
There was a problem hiding this comment.
No tests added for new patch path
Low Severity
The PR description requests adding tests for the change, but the diff only modifies runtime patching logic and adds no coverage validating the new ToolManager.execute_tool_call instrumentation behavior.
Contributor
Author
There was a problem hiding this comment.
There are existing tests for tool spans like test_agent_with_tools, but we don't test with the newest version here -- let me pull in the newest version
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 8.71s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 13729 uncovered lines. Files with missing lines (180)
Generated by Codecov Action |
alexander-alderman-webb
approved these changes
Feb 24, 2026
Comment on lines
+39
to
+40
| def _patch_execute_tool_call() -> None: | ||
| original_execute_tool_call = ToolManager.execute_tool_call |
Contributor
There was a problem hiding this comment.
we could maybe dedupe but the patches may diverge in future as well so I'm okay with either
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The internal function
ToolManager._call_toolwas removed. PatchToolManager.execute_tool_callinstead.Span from local testing:
Also:
Issues
Fixes #5518
Reminders
tox -e linters.feat:,fix:,ref:,meta:)