Skip to content

chore(deps): Bump eslint to v8 #5443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antonis merged 1 commit into from
Dec 5, 2025
Merged

chore(deps): Bump eslint to v8 #5443

antonis merged 1 commit into from
Dec 5, 2025

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Dec 5, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #5442

📜 Description

Bump eslint to v8 and (auto)fixes the formatting to align with the bump

💡 Motivation and Context

The latest JS SDK 10.29.0 bumps eslint to v8 causing a CI check failure

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Warnings
⚠️ Failed to run ./check-replay-stubs: Invalid git ref: deps/scripts/update-javascript.sh

Generated by 🚫 dangerJS against fe1bdcf

@antonis antonis mentioned this pull request Dec 5, 2025
Merged
@antonis antonis marked this pull request as ready for review December 5, 2025 08:29
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 512.40 ms 553.23 ms 40.83 ms
Size 43.75 MiB 48.07 MiB 4.32 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
b48c857+dirty 371.82 ms 376.63 ms 4.82 ms
e718799+dirty 481.58 ms 524.81 ms 43.23 ms
ff56633 463.52 ms 466.79 ms 3.27 ms
300c47d+dirty 509.61 ms 528.31 ms 18.69 ms
ae0e9ff+dirty 385.88 ms 403.54 ms 17.66 ms
028a929+dirty 479.78 ms 475.83 ms -3.95 ms
c67d99f+dirty 465.22 ms 497.10 ms 31.88 ms
1eed088+dirty 377.06 ms 365.22 ms -11.84 ms
e9ae3ed+dirty 526.77 ms 554.56 ms 27.79 ms
91d4b7d 406.98 ms 419.14 ms 12.16 ms

App size

Revision Plain With Sentry Diff
b48c857+dirty 17.75 MiB 19.68 MiB 1.94 MiB
e718799+dirty 43.75 MiB 47.99 MiB 4.24 MiB
ff56633 17.75 MiB 19.68 MiB 1.93 MiB
300c47d+dirty 43.75 MiB 47.99 MiB 4.24 MiB
ae0e9ff+dirty 17.75 MiB 19.71 MiB 1.96 MiB
028a929+dirty 43.75 MiB 47.99 MiB 4.24 MiB
c67d99f+dirty 43.75 MiB 48.05 MiB 4.30 MiB
1eed088+dirty 17.75 MiB 19.69 MiB 1.94 MiB
e9ae3ed+dirty 43.75 MiB 48.05 MiB 4.29 MiB
91d4b7d 17.75 MiB 19.68 MiB 1.94 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 364.19 ms 413.22 ms 49.03 ms
Size 43.94 MiB 48.90 MiB 4.96 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
b48c857+dirty 353.60 ms 411.52 ms 57.92 ms
e718799+dirty 521.13 ms 557.07 ms 35.94 ms
91d4b7d+dirty 359.58 ms 405.98 ms 46.40 ms
ff56633+dirty 324.65 ms 389.38 ms 64.72 ms
300c47d+dirty 372.92 ms 401.59 ms 28.67 ms
ae0e9ff+dirty 336.33 ms 381.12 ms 44.79 ms
028a929+dirty 385.59 ms 410.49 ms 24.90 ms
c67d99f+dirty 372.11 ms 398.96 ms 26.85 ms
1eed088+dirty 355.56 ms 384.47 ms 28.90 ms
e9ae3ed+dirty 448.73 ms 507.29 ms 58.55 ms

App size

Revision Plain With Sentry Diff
b48c857+dirty 7.15 MiB 8.41 MiB 1.26 MiB
e718799+dirty 43.94 MiB 48.82 MiB 4.88 MiB
91d4b7d+dirty 7.15 MiB 8.41 MiB 1.26 MiB
ff56633+dirty 7.15 MiB 8.41 MiB 1.26 MiB
300c47d+dirty 43.94 MiB 48.82 MiB 4.88 MiB
ae0e9ff+dirty 7.15 MiB 8.44 MiB 1.28 MiB
028a929+dirty 43.94 MiB 48.82 MiB 4.88 MiB
c67d99f+dirty 43.94 MiB 48.88 MiB 4.94 MiB
1eed088+dirty 7.15 MiB 8.42 MiB 1.27 MiB
e9ae3ed+dirty 43.94 MiB 48.87 MiB 4.93 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.80 ms 1220.39 ms 3.59 ms
Size 3.41 MiB 4.67 MiB 1.25 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
b48c857+dirty 1219.14 ms 1240.80 ms 21.66 ms
d8ec252+dirty 1207.53 ms 1214.22 ms 6.69 ms
5275213+dirty 1224.65 ms 1223.43 ms -1.22 ms
e9ae3ed+dirty 1217.55 ms 1213.53 ms -4.02 ms
c67d99f+dirty 1215.45 ms 1213.92 ms -1.53 ms
1eed088+dirty 1233.41 ms 1233.63 ms 0.22 ms
028a929+dirty 1192.81 ms 1192.37 ms -0.44 ms
dcebdb7+dirty 1199.17 ms 1206.65 ms 7.49 ms
3cf1cb0+dirty 1202.40 ms 1212.53 ms 10.13 ms
ff56633+dirty 1212.29 ms 1214.81 ms 2.52 ms

App size

Revision Plain With Sentry Diff
b48c857+dirty 2.63 MiB 3.96 MiB 1.33 MiB
d8ec252+dirty 2.63 MiB 3.87 MiB 1.24 MiB
5275213+dirty 3.41 MiB 4.59 MiB 1.18 MiB
e9ae3ed+dirty 3.41 MiB 4.59 MiB 1.18 MiB
c67d99f+dirty 3.41 MiB 4.59 MiB 1.18 MiB
1eed088+dirty 2.63 MiB 3.98 MiB 1.35 MiB
028a929+dirty 3.41 MiB 4.57 MiB 1.16 MiB
dcebdb7+dirty 2.63 MiB 3.99 MiB 1.36 MiB
3cf1cb0+dirty 2.63 MiB 4.01 MiB 1.38 MiB
ff56633+dirty 2.63 MiB 3.87 MiB 1.24 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1210.51 ms 1212.04 ms 1.53 ms
Size 3.41 MiB 4.67 MiB 1.25 MiB

Baseline results on branch: deps/scripts/update-javascript.sh

Startup times

Revision Plain With Sentry Diff
b48c857+dirty 1204.78 ms 1206.73 ms 1.96 ms
d8ec252+dirty 1223.06 ms 1219.64 ms -3.42 ms
5275213+dirty 1208.78 ms 1206.21 ms -2.57 ms
e9ae3ed+dirty 1208.33 ms 1209.12 ms 0.79 ms
c67d99f+dirty 1214.71 ms 1212.94 ms -1.77 ms
1eed088+dirty 1220.49 ms 1225.57 ms 5.08 ms
028a929+dirty 1211.19 ms 1211.10 ms -0.08 ms
dcebdb7+dirty 1225.80 ms 1231.29 ms 5.49 ms
3cf1cb0+dirty 1231.02 ms 1221.30 ms -9.72 ms
ff56633+dirty 1240.96 ms 1235.77 ms -5.19 ms

App size

Revision Plain With Sentry Diff
b48c857+dirty 3.19 MiB 4.53 MiB 1.35 MiB
d8ec252+dirty 3.19 MiB 4.44 MiB 1.25 MiB
5275213+dirty 3.41 MiB 4.59 MiB 1.18 MiB
e9ae3ed+dirty 3.41 MiB 4.59 MiB 1.18 MiB
c67d99f+dirty 3.41 MiB 4.59 MiB 1.18 MiB
1eed088+dirty 3.19 MiB 4.55 MiB 1.36 MiB
028a929+dirty 3.41 MiB 4.57 MiB 1.16 MiB
dcebdb7+dirty 3.19 MiB 4.56 MiB 1.37 MiB
3cf1cb0+dirty 3.19 MiB 4.58 MiB 1.39 MiB
ff56633+dirty 3.19 MiB 4.44 MiB 1.25 MiB

lucas-zimerman
lucas-zimerman approved these changes Dec 5, 2025
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonis antonis merged commit eae5106 into deps/scripts/update-javascript.sh Dec 5, 2025
166 of 184 checks passed
@antonis antonis deleted the antonis/bump-eslint branch December 5, 2025 14:28
antonis added a commit that referenced this pull request Dec 5, 2025
@github-actions @web-flow @antonis
chore(deps): update JavaScript SDK to v10.29.0 (#5442)
3e157d4 
* chore: update scripts/update-javascript.sh to 10.29.0

* chore(deps): Bump eslint to v8 (#5443)

---------

Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@alwx alwx Awaiting requested review from alwx

Assignees

No one assigned

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonis @lucas-zimerman