Skip to content

fix: forward enable logs/metrics options to native layer#2662

Merged
bitsandfoxes merged 3 commits intomainfrom
fix/forward-logs-metrics-kill-switch
May 6, 2026
Merged

fix: forward enable logs/metrics options to native layer#2662
bitsandfoxes merged 3 commits intomainfrom
fix/forward-logs-metrics-kill-switch

Conversation

@bitsandfoxes
Copy link
Copy Markdown
Contributor

Follow up on #2660 (and probably other native bumps)

The enable logs and metrics options need to be properly propagated to the native layers.

@bitsandfoxes bitsandfoxes changed the title fix: forward logs & metrics enable to native layer fix: forward enable logs/metrics options to native layer May 5, 2026
@bitsandfoxes bitsandfoxes merged commit ea10d40 into main May 6, 2026
20 of 29 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/forward-logs-metrics-kill-switch branch May 6, 2026 11:21
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 14683c4. Configure here.

#endif

Logger?.LogDebug("Setting EnableLogs: {0}", options.EnableLogs);
sentry_options_set_enable_logs(cOptions, options.EnableLogs ? 1 : 0);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing native stub for sentry_options_set_enable_logs

High Severity

The new sentry_options_set_enable_logs P/Invoke in SentryNativeBridge.cs is called unconditionally but lacks a corresponding stub in sentry_native_stubs.c. On Switch builds using the stub library, this causes an EntryPointNotFoundException during initialization, which disables all native Sentry features like scope synchronization and crash reporting.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 14683c4. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants