-
-
Notifications
You must be signed in to change notification settings - Fork 77
build(deps): bump next from 14.2.35 to 16.1.5 in /e2e-tests/test-applications/nextjs-14-test-app #1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Bumps [next](https://github.com/vercel/next.js) from 14.2.35 to 16.1.5. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.2.35...v16.1.5) --- updated-dependencies: - dependency-name: next dependency-version: 16.1.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
| "react": "^18", | ||
| "react-dom": "^18", | ||
| "next": "14.2.35" | ||
| "next": "16.1.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The nextjs-14-test-app is incorrectly upgraded to Next.js 16, breaking its dedicated tests and removing version-specific test coverage.
Severity: CRITICAL
Suggested Fix
Revert the dependency update in e2e-tests/test-applications/nextjs-14-test-app/package.json. The next package in this test application should remain on a Next.js 14.x version to maintain correct test coverage.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: e2e-tests/test-applications/nextjs-14-test-app/package.json#L14
Potential issue: The pull request updates the `next` dependency in
`nextjs-14-test-app/package.json` from version 14.x to 16.1.5. This change is incorrect
as this test application is specifically designed to validate integration with Next.js
14. A separate application, `nextjs-16-test-app`, already exists for testing Next.js 16.
This update will cause the `nextjs-14.test.ts` E2E test to fail due to structural
differences between Next.js 14 (which expects `src/app/layout.tsx`) and Next.js 16
(which uses `app/layout.tsx`). Consequently, this change eliminates test coverage for
Next.js 14.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "react": "^18", | ||
| "react-dom": "^18", | ||
| "next": "14.2.35" | ||
| "next": "16.1.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next.js 14 test app upgraded to incompatible version 16
High Severity
The nextjs-14-test-app is a version-specific test application designed to verify Sentry wizard integration with Next.js 14. This Dependabot PR upgrades next from 14.2.35 to 16.1.5, which defeats the purpose of this test app since there's already a separate nextjs-16-test-app for testing Next.js 16. The associated test file nextjs-14.test.ts will no longer be testing Next.js 14 behavior, leaving that version untested.
ahamedjobayer551-debug
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


Bumps next from 14.2.35 to 16.1.5.
Release notes
Sourced from next's releases.
... (truncated)
Commits
acba4a6v16.1.5e1d1fc6Add maximum size limit for postponed body parsing (#88175)500ec83fetch(next/image): reduce maximumResponseBody from 300MB to 50MB (#88588)1caaca3feat(next/image)!: addimages.maximumResponseBodyconfig (#88183)522ed84Sync DoS mitigations for React Flight8cad197[backport][cna] Ensure created app is not considered the workspace root in pn...2718661Backport/docs fixes (#89031)5333625Backport/docs fixes 16.1.5 (#88916)60de6c2v16.1.45f75d22backport: Only filter next config if experimental flag is enabled (#88733) (#...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.