feat(react-native): skip patch native files when expo CNG #1211

uragirii · 2026-02-08T16:01:02Z

Description

Adds check to see if you are in Expo CNG to skip the native file patching
Checks if ios and android folders are in .gitignore
Skips the step and prints a log to show that step is skipped
Added Sentry tracking for this
As this is my first contribution, please let me know if I missed something

AI Disclosure

The tests in this PR are written by Claude Code Sonnet 4.5.
Actual implemention of the feature is done by me, only *.test.ts files are generated based on my code

src/react-native/expo.ts

test/react-native/expo.test.ts

src/react-native/expo.ts

cursor · 2026-02-08T19:22:40Z

src/react-native/git.ts

+
+    return NATIVE_FOLDERS.every((folder) => {
+      return lines.some((line) => {
+        const lineWithoutComment = line.split('#')[0].trim();


Gitignore parser incorrectly strips mid-line hash characters

Low Severity

The line.split('#')[0] approach treats # anywhere on a line as a comment delimiter. Per the gitignore spec, # only starts a comment when it's the first non-whitespace character on the line — mid-line # is a literal part of the pattern. A gitignore entry like ios # native would be incorrectly parsed as matching ios, even though git treats the entire string (including the #) as a literal pattern. This could cause a false positive for isExpoCNG, leading to native file patching being skipped when it shouldn't be. A simpler approach — checking if the trimmed line starts with # to identify comment lines — would match gitignore semantics correctly.

codecov · 2026-02-09T09:58:51Z

Codecov Report

❌ Patch coverage is 72.88136% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.32%. Comparing base (51bb31c) to head (9a7f56c).
⚠️ Report is 56 commits behind head on master.

Files with missing lines	Patch %	Lines
src/react-native/react-native-wizard.ts	5.88%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
+ Coverage   36.26%   37.32%   +1.06%     
==========================================
  Files         144      154      +10     
  Lines       17746    18585     +839     
  Branches     1457     1558     +101     
==========================================
+ Hits         6435     6937     +502     
- Misses      11291    11630     +339     
+ Partials       20       18       -2

Flag	Coverage Δ
unit-tests	`37.32% <72.88%> (+1.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Lms24

Hey @uragirii thanks for opening this PR! I started CI to run our tests and lint jobs. Pretty sure there are still some formatting issues.

From my PoV the actual changes look good. Also gonna ask @antonis to take a look, as my ReactNative/Expo knowledge is very limited :D

antonis · 2026-02-10T10:15:20Z

src/react-native/react-native-wizard.ts

+  if (isExpo && (await isExpoCNG())) {
+    Sentry.setTag('expo-cng', true);
+    clack.log.info(
+      `Detected Expo Continous Native Generation (CNG) setup. Skipping native files patching.`,


Suggested change

`Detected Expo Continous Native Generation (CNG) setup. Skipping native files patching.`,

`Detected Expo Continuous Native Generation (CNG) setup. Skipping native files patching.`,

antonis · 2026-02-10T10:32:44Z

test/react-native/expo.test.ts

+      expect(git.areNativeFoldersInGitignore).not.toHaveBeenCalled();
+    });
+
+    test('handles errors from areNativeFoldersInGitignore gracefully', async () => {


h: Wdyt of catching possible errors like the ones tested here and handling the error gracefully. I would expect that if the detection fails the isExpoCNG function would return false.

good point, I've wrapped in try catch block so now it should work as expected

oops, used the wrong account here but its still me ;)

antonis

Thank you for your contribution @uragirii 🙇 Overall it looks great 🥇

I've left a few comments for possible improvements along with the sentry[bot] feedback.

We could also add a changelog entry. Something like:

  ## Unreleased

  - fix(react-native): Skip native file patching when Expo CNG is detected ([#1211](https://github.com/getsentry/sentry-wizard/pull/1211))

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-02-10T13:45:25Z

src/react-native/expo.ts

+  const iOSExists = fs.existsSync('ios');
+  const androidExists = fs.existsSync('android');
+
+  const bothNativeFoldersExist = iOSExists || androidExists;


Misleading variable name contradicts OR operator logic

Low Severity

The variable bothNativeFoldersExist is assigned using || (OR), so it's true when either folder exists. The name "both" strongly implies && (AND), meaning both must exist. The actual logic is correct for the function's intent, but a future maintainer reading if (!bothNativeFoldersExist) would naturally interpret it as "if not both exist" (i.e., at most one exists), when it actually means "if neither exists." A name like anyNativeFolderExists would accurately reflect the || semantics.

uragirii · 2026-02-10T16:10:21Z

Can someone run the ubuntu test CI again? It failed due to 500 from yarn install

feat(react-native): skip patch native files when expo CNG

b570541

cursor bot reviewed Feb 8, 2026

View reviewed changes

src/react-native/expo.ts Show resolved Hide resolved

fix: cursor comment to see if native folders exist

eef456f

cursor bot reviewed Feb 8, 2026

View reviewed changes

test/react-native/expo.test.ts Show resolved Hide resolved

fix: update tests

c9164b8

sentry bot reviewed Feb 8, 2026

View reviewed changes

src/react-native/expo.ts Show resolved Hide resolved

cursor bot reviewed Feb 8, 2026

View reviewed changes

Lms24 reviewed Feb 9, 2026

View reviewed changes

antonis requested review from alwx and antonis February 9, 2026 10:06

antonis reviewed Feb 10, 2026

View reviewed changes

uragirii added 2 commits February 10, 2026 19:06

fix(react-native): handle pr comments

c685795

feat(react-native): added unreleased entry in changelog

9a7f56c

cursor bot reviewed Feb 10, 2026

View reviewed changes

	`Detected Expo Continous Native Generation (CNG) setup. Skipping native files patching.`,
	`Detected Expo Continuous Native Generation (CNG) setup. Skipping native files patching.`,

Uh oh!

feat(react-native): skip patch native files when expo CNG #1211

Are you sure you want to change the base?

feat(react-native): skip patch native files when expo CNG #1211

Conversation

uragirii commented Feb 8, 2026

Description

AI Disclosure

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot Feb 8, 2026

Choose a reason for hiding this comment

Gitignore parser incorrectly strips mid-line hash characters

Uh oh!

codecov bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

antonis Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

antonis Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

apoorv-kansal-mxm Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

uragirii Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 10, 2026

Choose a reason for hiding this comment

Misleading variable name contradicts OR operator logic

Uh oh!

uragirii commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Feb 9, 2026 •

edited

Loading