Skip to content

fix(logs): update withoutLoggingSupport to remove platforms which support logs #102398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaMoelans wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(logs): update withoutLoggingSupport to remove platforms which support logs #102398

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6edb52e
Update withoutLoggingSupport to remove platforms
JoshuaMoelans Oct 30, 2025
64dc9ec
Update withoutLoggingSupport by removing platforms
JoshuaMoelans Oct 30, 2025
73b5b10
:hammer_and_wrench: apply pre-commit fixes
getsantry[bot] Oct 30, 2025
4eb619d
Update withoutLoggingSupport to exclude 'unreal'
JoshuaMoelans Oct 30, 2025
e684c44
:hammer_and_wrench: apply pre-commit fixes
getsantry[bot] Oct 30, 2025
be51b21
also remove unity from withoutLoggingSupport
JoshuaMoelans Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions static/app/data/platformCategories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,16 +379,7 @@ export const withLoggingOnboarding: Set<PlatformKey> = new Set([
]);

// List of platforms that do not have logging support. We make use of this list in the product to not provide any Logging
export const withoutLoggingSupport: Set<PlatformKey> = new Set([
'cocoa-objc',
'cocoa-swift',
'elixir',
'dotnet',
'php-symfony',
Copy link
Member

@priscilawebdev priscilawebdev Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to add the 'logs' checkbox for php-symfony and maybe other platforms too? maybe in a follow-up?

Image

Copy link
Member Author

@JoshuaMoelans JoshuaMoelans Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a follow-up in #104234

'unity',
Copy link
Member

@priscilawebdev priscilawebdev Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on our official docs, we don't yet have logs for unity. Are we planning to add that?

Copy link
Member Author

@JoshuaMoelans JoshuaMoelans Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the docs will come with the 'full' release in Unity 4.0.0 (they were already moved out of experimental in the beta)

'unreal',
'native',
]);
export const withoutLoggingSupport: Set<PlatformKey> = new Set(['elixir']);

// List of platforms that have metrics onboarding checklist content
export const withMetricsOnboarding: Set<PlatformKey> = new Set([
Comment on lines 379 to 385

This comment was marked as outdated.

Sign in to view

Copy link
Member Author

@JoshuaMoelans JoshuaMoelans Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this separately in #104234

Expand Down
Loading