chore: update SDK onboarding pages #104234
Conversation
github-actions
bot
added
the
Scope: Frontend
JoshuaMoelans
changed the title
- fix link - add minidump storage setting
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104234 +/- ##
===========================================
- Coverage 80.60% 80.60% -0.01%
===========================================
Files 9333 9333
Lines 398600 398597 -3
Branches 25497 25496 -1
===========================================
- Hits 321275 321272 -3
Misses 76875 76875
Partials 450 450 |
| import {StepType} from 'sentry/components/onboarding/gettingStartedDoc/types'; | ||
| import {t, tct} from 'sentry/locale'; | ||
|
|
||
| type Params = DocsParams; |
There was a problem hiding this comment.
we can use the DocsParams directly instead of using type Params
| onboarding, | ||
| feedbackOnboardingCrashApi: crashReport, | ||
| crashReportOnboarding: crashReport, | ||
| logsOnboarding: logs, |
There was a problem hiding this comment.
do we need to add a performanceOnboarding too?
| params.isPerformanceSelected | ||
| ? ` | ||
| // Set traces_sample_rate to 1.0 to capture 100% of transactions for tracing. | ||
| // We recommend adjusting this value in production. | ||
| Settings->TracesSampleRate = 1.0f;` | ||
| : '' |
There was a problem hiding this comment.
I would add tracing in a separate PR
| { | ||
| type: 'text', | ||
| text: tct( | ||
| 'To enable performance monitoring, set the [code:TracesSampleRate] option in the Sentry configuration window. For example, set it to [code:1.0] to capture 100% of transactions.', |
There was a problem hiding this comment.
aren't we calling it tracing?
| 'cocoa-objc', | ||
| 'cocoa-swift', |
There was a problem hiding this comment.
I noticed that we have several references to these platforms in the codebase, but we don’t present them as options when users create a project. My understanding is that users can also create projects through the public API - Is that why we need to include these platforms here?
Continuing from #102398, to be merged after that one was merged.
We add the
logsonboarding for each of the platforms that now support logs.There is also some additional cleanup & adding of
tracingto the Getting Started docs.ToDo
logscheckbox to project onboarding page for each of these SDKs (see original comment)