fix(api): Scope clientSecret visibility to app owner in serializer#118369
Open
michelletran-sentry wants to merge 2 commits into
Open
fix(api): Scope clientSecret visibility to app owner in serializer#118369michelletran-sentry wants to merge 2 commits into
michelletran-sentry wants to merge 2 commits into
Conversation
ApiApplicationSerializer previously exposed clientSecret for any OAuth app created in the last 5 minutes, regardless of who was viewing it. Add an ownership check so the secret is only included when the requesting user matches the application owner. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
michelletran-sentry
force-pushed
the
fix/api-app-secret-owner-scope
branch
from
6b0c483 to
328f034
Compare
The previous commit hid clientSecret from all non-owners. This broke callers that serialize ApiApplication without passing a user (e.g. the getsentry instance-level OAuth admin endpoint). Now only hide the secret when a real user is provided and they are not the owner. Callers that omit the user param retain prior behavior. Co-Authored-By: Claude <noreply@anthropic.com>
michelletran-sentry
force-pushed
the
fix/api-app-secret-owner-scope
branch
from
328f034 to
100e9b0
Compare
nora-shap
approved these changes
Jun 24, 2026
nora-shap
left a comment
nora-shap
left a comment
Member
There was a problem hiding this comment.
Nice fix! Make sure there is a ticket for the work described in the TODO so it doesn't get forgotten 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApiApplicationSerializer previously exposed clientSecret for any OAuth app created in the last 5 minutes, regardless of who was viewing it. Add an ownership check so the secret is only included when the requesting user matches the application owner.
Fixes: https://github.com/getsentry/getsentry/issues/20229
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.