build(deps): Bump eslint-plugin-react-you-might-not-need-an-effect to 1.0.1#118372
Draft
ryan953 wants to merge 1 commit into
Draft
build(deps): Bump eslint-plugin-react-you-might-not-need-an-effect to 1.0.1#118372ryan953 wants to merge 1 commit into
ryan953 wants to merge 1 commit into
Conversation
… 1.0.1 Update eslint-plugin-react-you-might-not-need-an-effect from 0.5.3 to 1.0.1. The 1.0 release removed the no-empty-effect and no-manage-parent rules and added a new recommended no-external-store-subscription rule. Update the flat config accordingly: drop the two removed rule references (which would otherwise error) and disable the new rule to preserve the existing behavior of enabling only no-derived-state. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
cb8a568 to
7363d77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
eslint-plugin-react-you-might-not-need-an-effectfrom 0.5.3 to 1.0.1.The 1.0 release removed two rules and added one, so the flat config needs adjusting alongside the bump:
no-empty-effectandno-manage-parentrule references. Both rules no longer exist in the plugin, and ESLint errors on references to unknown rules.no-external-store-subscription: 'off'. This is a new rule that the plugin'srecommendedconfig enables by default; since this config block spreads...configs.recommendedand intentionally enables onlyno-derived-state, the new rule is disabled to keep current behavior.No change to which violations are enforced —
no-derived-stateremains the only active rule. Note that 1.0.1 has improvedno-derived-statedetection, so CI may surface new violations in existing code that the older version missed.