ref(project-creation): Polish the SCM alert frequency component#118375
Open
jaydgoss wants to merge 7 commits into
Open
ref(project-creation): Polish the SCM alert frequency component#118375jaydgoss wants to merge 7 commits into
jaydgoss wants to merge 7 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit aba9239. Configure here.
Rework the alert-frequency options to match the latest Figma. The custom threshold form now lives inside the selected card instead of below it with a left-border accent bar, and only mounts when Custom is selected. The threshold input and metric select are equal width at the standard form size. Add the High priority issues description line and a footer note that alerts can be changed after project creation. Update the option copy to Custom threshold and I'll set up alerts later. ScmAlertOptionCard now wraps the radio row and its children in one bordered card and accepts an optional description. Claude-Session: https://claude.ai/code/session_01F8yRVeJRYS7BKpoxQHASq2
…enus Expand and collapse the custom-threshold form with the same height tween ScmCollapsibleSection uses, so it composes with scmCreateProject's layout="position" group instead of popping in. Render the threshold and interval select menus in a body portal so they are not clipped or flipped by the card and animation overflow:hidden bounds. Claude-Session: https://claude.ai/code/session_01F8yRVeJRYS7BKpoxQHASq2
Move the card padding onto the header button so the whole collapsed card is clickable to its edges instead of leaving a dead padding ring. Give the expanded body its own right and bottom padding so input focus rings clear the animated overflow:hidden bounds. Lay the radio, label, and description out in a 2x2 grid so the radio centers on the label row and the description sits beneath the label. Claude-Session: https://claude.ai/code/session_01F8yRVeJRYS7BKpoxQHASq2
…bels Extract the height + fade tween shared by ScmCollapsibleSection and ScmAlertOptionCard into ScmCollapsibleReveal so the expand/collapse timing lives in one place. Make the option label always bold and drop it to the same size as its description, matching the new design. Claude-Session: https://claude.ai/code/session_01F8yRVeJRYS7BKpoxQHASq2
…y UI The design specifies type and control sizes that do not map cleanly to scraps tokens, so use the md radio and text sizes (and no label/description row gap) on the option card, and the md info icon and helper text on the footer, to stay within the design system instead of matching the mock pixel for pixel. Claude-Session: https://claude.ai/code/session_01F8yRVeJRYS7BKpoxQHASq2 fx
…x body indent Drop the threshold input and metric select to a single column below the md breakpoint so they are not cramped on narrow screens. Correct the expanded body indent to the md radio's 24px width so it lines up under the label again after the radio grew from sm to md. Claude-Session: https://claude.ai/code/session_01F8yRVeJRYS7BKpoxQHASq2
The alert option label was renamed from "I'll create my own alerts later" to "I'll set up alerts later" earlier in this branch, but the back-nav acceptance test still selected the radio by the old text and timed out. Update its xpath substrings to match the current label.
jaydgoss
force-pushed
the
jaygoss/vdy-77-project-creation-ui-polish-cont
branch
from
2dbbc40 to
967cfc5
Compare
jaydgoss
force-pushed
the
jaygoss/vdy-77-scm-alert-frequency-polish
branch
from
aba9239 to
6e8ef78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Reworks the SCM project-creation alert-frequency component to match the updated design: bordered radio cards, the custom-threshold form expanding inside the selected card with an animated reveal, and a set of layout and accessibility fixes on top.
Details
Stack
Continues the VDY-77 project-creation UI polish work. Base branch is jaygoss/vdy-77-project-creation-ui-polish-cont (#118193).