Validate explore column editor fields#118377
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7bc6137. Configure here.
| if (validatedFields.length < fields.length) { | ||
| setFields([...validatedFields]); | ||
| } | ||
| }, [fields, setFields, validatedFields]); |
There was a problem hiding this comment.
Invalid columns persist when lengths match
Low Severity
The effect that syncs query fields with validation only runs when validatedFields is shorter than fields. If an invalid column is dropped but the remaining list has the same length (e.g. duplicate valid columns plus one invalid name), setFields never runs and the invalid column can stay in the URL and span samples table.
Reviewed by Cursor Bugbot for commit 7bc6137. Configure here.


Summary
Test plan