fix(listBox): fix virtualized scrolling when mouse is used#118380
Merged
Conversation
apparently, listState.selectionManager.focuseKey is empty string in those cases. The effect that scrolls elements into view was only meant for keyboard navigation, but it effectively stopped scrolling on virtualized lists when the scrollbar is dragged because it always instantly scrolls back to the focused element. the fix is to widen the early return statement to include empty string
github-actions
Bot
added
the
Scope: Frontend
Collaborator
Author
|
@JonasBa FYI 😂 |
nsdeschenes
approved these changes
Jun 24, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4130770. Configure here.
Contributor
|
Please kill this list component, I never want to see it ever again |
Collaborator
Author
|
okay this is the wrong fix. I thought empty string is just another falsy value that we are getting, but it’s the actually selected value :/ I have to find another fix |
…keyboard the effect was meant for cmd-k keyboard navigation and should not have an impact on scrolling with the mouse / dragging the scrollbar
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
this includes keyboard and virtual (for screen reader navigation) for auto focus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the effect was meant for cmd-k keyboard navigation and should not have an impact on scrolling with the mouse / dragging the scrollbar