Skip to content

fix(project-creation): Forward the SCM product selection to setup docs#118390

Open
jaydgoss wants to merge 1 commit into
jaygoss/vdy-77-project-creation-ui-polish-contfrom
jaygoss/scm-create-project-forward-products
Open

fix(project-creation): Forward the SCM product selection to setup docs#118390
jaydgoss wants to merge 1 commit into
jaygoss/vdy-77-project-creation-ui-polish-contfrom
jaygoss/scm-create-project-forward-products

Conversation

@jaydgoss

Copy link
Copy Markdown
Member

TLDR

The SCM create-project flow lets you pick products upfront, but the selection was dropped when navigating to the getting-started setup docs. This forwards it as the product query so the instructions match what was chosen.

Details

  • handleComplete now navigates to getting-started with query: {product: selectedFeatures} instead of dropping the selection. The getting-started page (ProjectInstallPlatform) seeds its product selection from location.query.product, so the setup docs now reflect the upfront choice.
  • Mirrors the SCM onboarding flow, which already forwards the selection the same way (ScmProjectDetails -> goNextStep). The classic createProject flow selects products on the getting-started page itself, so it has nothing to forward.
  • Adds a test asserting the product query is forwarded on creation.

Stack

Based on jaygoss/vdy-77-project-creation-ui-polish-cont (#118193), where the SCM create-project flow lives.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 24, 2026
@jaydgoss jaydgoss marked this pull request as ready for review June 24, 2026 19:35
@jaydgoss jaydgoss requested a review from a team as a code owner June 24, 2026 19:35
The SCM create-project flow picks products upfront in ScmFeatureSelectionPanel,
but handleComplete navigated to getting-started without them, so the setup docs
ignored the choice. Forward the selection as the product query, which the
getting-started page seeds from. Mirrors the SCM onboarding flow (ScmProjectDetails
-> goNextStep); classic createProject selects products on that page instead, so it
forwards nothing.
@jaydgoss jaydgoss force-pushed the jaygoss/vdy-77-project-creation-ui-polish-cont branch from 2dbbc40 to 967cfc5 Compare June 24, 2026 23:47
@jaydgoss jaydgoss requested a review from a team as a code owner June 24, 2026 23:47
@jaydgoss jaydgoss force-pushed the jaygoss/scm-create-project-forward-products branch from 226526d to a21c2f4 Compare June 24, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants