chore(preprod): Remove preprod-enforce-size-quota feature flag#118392
Merged
NicoHinderling merged 1 commit intoJun 24, 2026
Conversation
Graduate size quota enforcement to always-on. The flag previously gated an early return in has_size_quota() that skipped the quota check entirely when disabled; now the check always runs. Remove the flag registration, the gate in has_size_quota(), and the flag from the affected task tests.
github-actions
Bot
added
the
Scope: Backend
adrianviquez
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Graduates preprod size quota enforcement to always-on by removing the
organizations:preprod-enforce-size-quotafeature flag.Previously,
has_size_quota()short-circuited with an earlyreturn Truewhenever the flag was disabled, so size quota was never enforced for orgs without the flag. The flag has served its rollout purpose; this bakes in the enforced behavior so the quota check always runs.Changes
src/sentry/features/temporary.py.has_size_quota()(src/sentry/preprod/quotas.py); it now always callsquotas.backend.has_usage_quota(..., SIZE_ANALYSIS).self.feature([...])blocks intests/sentry/preprod/test_tasks.py.The sibling
organizations:preprod-enforce-distribution-quotaflag is intentionally left untouched.