Skip to content

chore: pin GitHub Actions to full-length commit SHAs#7831

Open
joshuarli wants to merge 1 commit intomasterfrom
pin-gha-actions
Open

chore: pin GitHub Actions to full-length commit SHAs#7831
joshuarli wants to merge 1 commit intomasterfrom
pin-gha-actions

Conversation

@joshuarli
Copy link
Copy Markdown
Member

Summary

  • Pin all GitHub Actions references in .github/ workflow files to full-length commit SHAs

Generated by devenv pin_gha.

🤖 Generated with Claude Code

@joshuarli joshuarli requested review from a team as code owners March 23, 2026 19:59
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@631a55b12751854ce901bb631d5902ceb48146f7 # stable
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned SHA from force-pushed branch will be garbage-collected

High Severity

The dtolnay/rust-toolchain action uses force-pushed branches (stable, nightly, etc.) that are periodically rebased. The repository explicitly documents that any commit not in the master branch history will eventually be garbage-collected. The devenv pin_gha tool resolved @stable to the current HEAD of the stable branch, but that SHA will become unreachable after the next force-push, breaking CI. The correct approach per the maintainer is to pin to a SHA from the master branch and add toolchain: stable to the with: block.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants