Skip to content

ref(eap-outcomes): use sentry-options to change which timestamp to use#7838

Open
kenzoengineer wants to merge 10 commits intomasterfrom
kjiang/use_item_timestamp_option
Open

ref(eap-outcomes): use sentry-options to change which timestamp to use#7838
kenzoengineer wants to merge 10 commits intomasterfrom
kjiang/use_item_timestamp_option

Conversation

@kenzoengineer
Copy link
Copy Markdown
Member

This is a duplicate of #7834, using sentry-options instead of the old config method.

#7836 should be merged first to ensure all the scaffolding works in production.

Because this is a duplicate, the logic, usage, and tests all mirror #7834. The only thing I've added is we use sentry-options instead.

@kenzoengineer kenzoengineer requested a review from a team as a code owner March 24, 2026 21:24
@MeredithAnya MeredithAnya force-pushed the kjiang/setup-sentry-options branch from 6c99601 to 77cf17e Compare March 25, 2026 18:16
Base automatically changed from kjiang/setup-sentry-options to master March 25, 2026 21:18
}

#[test]
fn poll_updates_use_item_timestamp_dynamically() {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this extra test to make sure toggling it actually does something

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@kenzoengineer
Copy link
Copy Markdown
Member Author

@MeredithAnya @onewland

and cc @hubertdeng123

init(), options() and .get() now all return an Err and won't panic. However, I made an explicit decision in this PR to have all of them panic (fail loudly) when there is an error. You two are owners of this code so I wanted to see what you guys thought about that, and whether you want to gracefully handle anything?

@kenzoengineer kenzoengineer requested a review from onewland March 26, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants