Open
Conversation
Co-Authored-By: bmckerry <110857332+bmckerry@users.noreply.github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Sentry-core version split breaks Sentry event capture in arroyo
- Updated
rust_snubato usesentry 0.46.2and refreshed the lockfile so bothsentryandsentry_arroyoresolve to the samesentry-core 0.46.2runtime state.
- Updated
Or push these changes by commenting:
@cursor push 2d3942baba
Preview (2d3942baba)
diff --git a/rust_snuba/Cargo.lock b/rust_snuba/Cargo.lock
--- a/rust_snuba/Cargo.lock
+++ b/rust_snuba/Cargo.lock
@@ -1961,7 +1961,7 @@
"httpdate",
"itoa",
"pin-project-lite",
- "socket2 0.5.6",
+ "socket2 0.4.10",
"tokio",
"tower-service",
"tracing",
@@ -3845,7 +3845,7 @@
"reqwest 0.11.27",
"schemars",
"scopeguard",
- "sentry 0.41.0",
+ "sentry",
"sentry-kafka-schemas",
"sentry-options",
"sentry_arroyo",
@@ -4058,27 +4058,6 @@
[[package]]
name = "sentry"
-version = "0.41.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "507ac2be9bf2da56c831da57faf1dadd81f434bd282935cdb06193d0c94e8811"
-dependencies = [
- "httpdate",
- "native-tls",
- "reqwest 0.12.28",
- "sentry-anyhow",
- "sentry-backtrace 0.41.0",
- "sentry-contexts 0.41.0",
- "sentry-core 0.41.0",
- "sentry-debug-images 0.41.0",
- "sentry-log",
- "sentry-panic 0.41.0",
- "sentry-tracing 0.41.0",
- "tokio",
- "ureq",
-]
-
-[[package]]
-name = "sentry"
version = "0.46.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "d92d893ba7469d361a6958522fa440e4e2bc8bf4c5803cd1bf40b9af63f8f9a8"
@@ -4088,12 +4067,14 @@
"native-tls",
"reqwest 0.12.28",
"sentry-actix",
- "sentry-backtrace 0.46.2",
- "sentry-contexts 0.46.2",
- "sentry-core 0.46.2",
- "sentry-debug-images 0.46.2",
- "sentry-panic 0.46.2",
- "sentry-tracing 0.46.2",
+ "sentry-anyhow",
+ "sentry-backtrace",
+ "sentry-contexts",
+ "sentry-core",
+ "sentry-debug-images",
+ "sentry-log",
+ "sentry-panic",
+ "sentry-tracing",
"tokio",
"ureq",
]
@@ -4108,58 +4089,33 @@
"actix-web",
"bytes",
"futures-util",
- "sentry-core 0.46.2",
+ "sentry-core",
]
[[package]]
name = "sentry-anyhow"
-version = "0.41.0"
+version = "0.46.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1fce8e095bb4e66cbf92f7eb3fb0ff7014f7943de3e4f55b3ef69261cf32d913"
+checksum = "b6924ad794a4786c26739816afc9b54b31c13cad479698f53c0398c5f6400954"
dependencies = [
"anyhow",
- "sentry-backtrace 0.41.0",
- "sentry-core 0.41.0",
+ "sentry-backtrace",
+ "sentry-core",
]
[[package]]
name = "sentry-backtrace"
-version = "0.41.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "eb4416302fa5325181a120e0fe7d4afd83cd95e52a9b86afa34a8161383fe0dc"
-dependencies = [
- "backtrace",
- "regex",
- "sentry-core 0.41.0",
-]
-
-[[package]]
-name = "sentry-backtrace"
version = "0.46.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "5f8784d0a27b5cd4b5f75769ffc84f0b7580e3c35e1af9cd83cb90b612d769cc"
dependencies = [
"backtrace",
"regex",
- "sentry-core 0.46.2",
+ "sentry-core",
]
[[package]]
name = "sentry-contexts"
-version = "0.41.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "936752f42b6f651dcb257da0bfa235ecc79e82011c49ed3383c212cc582263ff"
-dependencies = [
- "hostname",
- "libc",
- "os_info",
- "rustc_version",
- "sentry-core 0.41.0",
- "uname",
-]
-
-[[package]]
-name = "sentry-contexts"
version = "0.46.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "0e5eb42f4cd4f9fdfec9e3b07b25a4c9769df83d218a7e846658984d5948ad3e"
@@ -4168,30 +4124,18 @@
"libc",
"os_info",
"rustc_version",
- "sentry-core 0.46.2",
+ "sentry-core",
"uname",
]
[[package]]
name = "sentry-core"
-version = "0.41.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "00e9bd2cadaeda3af41e9fa5d14645127d6f6a4aec73da3ae38e477ecafd3682"
-dependencies = [
- "rand 0.9.2",
- "sentry-types 0.41.0",
- "serde",
- "serde_json",
-]
-
-[[package]]
-name = "sentry-core"
version = "0.46.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "b0b1e7ca40f965db239da279bf278d87b7407469b98835f27f0c8e59ed189b06"
dependencies = [
"rand 0.9.2",
- "sentry-types 0.46.2",
+ "sentry-types",
"serde",
"serde_json",
"url",
@@ -4199,22 +4143,12 @@
[[package]]
name = "sentry-debug-images"
-version = "0.41.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "e1e074fe9a0970c91999b23ed3195e6e30990d589fba3a68f20a1686af0f5cda"
-dependencies = [
- "findshlibs",
- "sentry-core 0.41.0",
-]
-
-[[package]]
-name = "sentry-debug-images"
version = "0.46.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "002561e49ea3a9de316e2efadc40fae553921b8ff41448f02ea85fd135a778d6"
dependencies = [
"findshlibs",
- "sentry-core 0.46.2",
+ "sentry-core",
]
[[package]]
@@ -4239,12 +4173,13 @@
[[package]]
name = "sentry-log"
-version = "0.41.0"
+version = "0.46.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a693f27e3f63ae085cf7c176b5c44038af27c8a0170d01db30ccf776c2d40ce3"
+checksum = "e200860daf76e09f9ad111bce25928f96bedbb84bc5934b37f05bb445727c70e"
dependencies = [
+ "bitflags 2.11.0",
"log",
- "sentry-core 0.41.0",
+ "sentry-core",
]
[[package]]
@@ -4270,7 +4205,7 @@
"chrono",
"jsonschema 0.36.0",
"openssl",
- "sentry 0.46.2",
+ "sentry",
"serde",
"serde_json",
"tempfile",
@@ -4279,69 +4214,29 @@
[[package]]
name = "sentry-panic"
-version = "0.41.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "4651d34f3ba649d9e6dc1268443cae6728b8f741c2f0264004f8ecf5b247330d"
-dependencies = [
- "sentry-backtrace 0.41.0",
- "sentry-core 0.41.0",
-]
-
-[[package]]
-name = "sentry-panic"
version = "0.46.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "8906f8be87aea5ac7ef937323fb655d66607427f61007b99b7cb3504dc5a156c"
dependencies = [
- "sentry-backtrace 0.46.2",
- "sentry-core 0.46.2",
+ "sentry-backtrace",
+ "sentry-core",
]
[[package]]
name = "sentry-tracing"
-version = "0.41.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "c25c47d36bc80c74d26d568ffe970c37b337c061b7234ad6f2d159439c16f000"
-dependencies = [
- "bitflags 2.11.0",
- "sentry-backtrace 0.41.0",
- "sentry-core 0.41.0",
- "tracing-core",
- "tracing-subscriber",
-]
-
-[[package]]
-name = "sentry-tracing"
version = "0.46.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "5b07eefe04486316c57aba08ab53dd44753c25102d1d3fe05775cc93a13262d9"
dependencies = [
"bitflags 2.11.0",
- "sentry-backtrace 0.46.2",
- "sentry-core 0.46.2",
+ "sentry-backtrace",
+ "sentry-core",
"tracing-core",
"tracing-subscriber",
]
[[package]]
name = "sentry-types"
-version = "0.41.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a08e7154abe2cd557f26fd70038452810748aefdf39bc973f674421224b147c1"
-dependencies = [
- "debugid",
- "hex",
- "rand 0.9.2",
- "serde",
- "serde_json",
- "thiserror 2.0.18",
- "time",
- "url",
- "uuid",
-]
-
-[[package]]
-name = "sentry-types"
version = "0.46.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "567711f01f86a842057e1fc17779eba33a336004227e1a1e7e6cc2599e22e259"
@@ -4369,7 +4264,7 @@
"parking_lot",
"rand 0.8.5",
"rdkafka",
- "sentry-core 0.46.2",
+ "sentry-core",
"serde",
"serde_json",
"thiserror 1.0.58",
diff --git a/rust_snuba/Cargo.toml b/rust_snuba/Cargo.toml
--- a/rust_snuba/Cargo.toml
+++ b/rust_snuba/Cargo.toml
@@ -41,7 +41,7 @@
regex = "1.11.1"
reqwest = { version = "0.11.11", features = ["stream"] }
schemars = { version = "0.8.16", features = ["uuid1"] }
-sentry = { version = "0.41.0", default-features = false, features = [
+sentry = { version = "0.46.2", default-features = false, features = [
# default features, except `release-health` is disabled
"backtrace",
"contexts",This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
| sentry-options = "1.0.3" | ||
| sentry_protos = "0.7.0" | ||
| sentry_arroyo = { version = "2.37.0", features = ["ssl"] } | ||
| sentry_arroyo = { version = "2.38.5", features = ["ssl"] } |
There was a problem hiding this comment.
Sentry-core version split breaks Sentry event capture in arroyo
Medium Severity
Bumping sentry_arroyo to 2.38.5 changes its transitive dependency from sentry-core 0.41.0 to sentry-core 0.46.2, while the main sentry crate remains pinned at 0.41.0 (which depends on sentry-core 0.41.0). In Rust, these are two completely separate crate instances with independent global state and thread-local Hub storage. The sentry::init() call only configures the 0.41.0 Hub, so any Sentry event capture within sentry_arroyo (using the 0.46.2 Hub) will silently go nowhere. Previously both crates shared sentry-core 0.41.0, so Sentry context propagated correctly into arroyo processing code.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: bmckerry 110857332+bmckerry@users.noreply.github.com