Conversation
… log, rather than _current_
shashjar
commented
Mar 30, 2026
| partition.index, | ||
| CommitLogEntry { | ||
| offset, | ||
| offset: offset + 1, |
Member
Author
There was a problem hiding this comment.
Would like to confirm two things with EAP:
- Were these offset semantics intended behavior for any reason?
- Are there any consumers of Snuba commit log entries other than the
SynchronizedConsumerimplementation (post-process forwarder consumers)? If so and they rely on the current offset semantics, we may have to rethink our approach here.
Member
Author
There was a problem hiding this comment.
For (2), I believe the only other consumer of the Snuba commit log is the subscription consumer. It looks to me like the subscription consumer cares only about offset intervals (not absolute values), so I think it should be unaffected by the change in this PR (except for maybe immediately after rollout?).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/getsentry/issue/ID-1390/investigate-end-to-end-slo-burn-in-geicogs
Fixes a bug in the Snuba Rust consumer. When producing commit log entries, the Rust consumer currently uses the current offset (the offset of the latest event which has been persisted to CH). By contrast, the Python consumer uses the next offset (the offset of the first event which has not yet been persisted to CH).
Sentry-side, the SynchronizedConsumer implementation blocks
if message.offset >= remote_offset. It therefore expects theremote_offsetit got from the Snuba commit log to be the offset of the next event, not the current one.This off-by-one bug has been causing increased event latency in the Geico and Goldman Sachs regions since we increased the number of partitions in the PPF for INC-2007, since lone events spend more time waiting in sparse partitions for another event to enter (SLO burn, increased PPF consumer latency).
This PR brings the Rust consumer into line with the Python consumer and the SynchronizedConsumer's expectations.
More context / discussion in this Slack thread