fix(cli): Replace process.exit(130) with thrown error for graceful cleanup#213
Draft
fix(cli): Replace process.exit(130) with thrown error for graceful cleanup#213
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
…eanup readSingleKey() called process.exit(130) on Ctrl+C, bypassing Sentry span completion and telemetry flush. Throw UserAbortError instead, allowing callers to clean up before exiting. Warden finding find-warden-bugs-bf627437 Severity: high Co-Authored-By: Warden <noreply@getsentry.com>
dcramer
force-pushed
the
warden-sweep/cd745cc3/bf627437
branch
from
65e473d to
15e13e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces direct
process.exit(130)inreadSingleKey()with a thrownUserAbortError, allowing Sentry spans to complete and telemetry to flush before exit.readSingleKey()captures Ctrl+C as raw byte\x03(stdin in raw mode), bypassing the SIGINT handler entirely. The immediateprocess.exit(130)skipped span completion, log cleanup, andflushSentry(). Now callers can catchUserAbortErrorand exit gracefully.Automated fix for Warden finding find-warden-bugs-bf627437 (high, detected by find-warden-bugs).
Ref #212