fix(cli): Normalize path separators in synthetic file changes#217
Merged
fix(cli): Normalize path separators in synthetic file changes#217
Conversation
createSyntheticFileChange used relative() without normalizePath(), producing backslash paths on Windows that would never match matchGlob's forward-slash regex patterns. Warden finding find-warden-bugs-8ed759ef Severity: high Co-Authored-By: Warden <noreply@getsentry.com>
dcramer
force-pushed
the
warden-sweep/cd745cc3/8ed759ef
branch
from
bb8956c to
af904c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps
relative()withnormalizePath()increateSyntheticFileChange, consistent with all other path handling in the same file.On Windows,
relative()returns backslash paths that would never matchmatchGlob's forward-slash regex patterns, causing schedule triggers to silently analyze zero files.Automated fix for Warden finding find-warden-bugs-8ed759ef (high, detected by find-warden-bugs).
Ref #212