Conversation
Contributor
Author
EbonJaeger
previously approved these changes
Sep 4, 2023
Member
EbonJaeger
left a comment
There was a problem hiding this comment.
LGTM, though the changes in config.load.go look like a bit more than just changing out the logger. Change scope is something to watch out for in the future, because it makes it harder to review and harder to debug later to figure out what changed caused an issue.
Contributor
Author
|
I agree with you, but the code was way more duplicated than I could tolerate 😬 I can split the commit anyway. |
silkeh
requested changes
Sep 4, 2023
Member
silkeh
left a comment
There was a problem hiding this comment.
Great work! I have a few relatively minor comments, but it looks fine otherwise 🙂
Contributor
Author
|
All sorted, I also squashed the commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slog is the new structured logging library from the Go project itself. It is available as an experimental package for Go 1.20 and was upstreamed in Go 1.21. This makes it a perfect candidate for our tooling, because:
This PR only replaces waterlog with slog, using its TextHandler Handler. TextHandler is nowhere near the look of waterlog, but a custom Handler mimicking the old look is in the works and will come with a different PR in the near future.