Don't recurse infinitely into subdirectories#15
Open
EbonJaeger wants to merge 1 commit into
Open
Conversation
This fixes the issue where potentially the entire /usr/lib tree is added to the state map, adding hundreds of thousands of entries. This attempts to only recurse one subdirectory to try to match what the C usysconf did. With this commit, a first run only adds roughly 6200 entries. Still far higher than previous usysconf's 400, but at least it doesn't choke on a second run. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
EbonJaeger
force-pushed
the
no-recurse-subdirs
branch
from
05e4654 to
b28be74
Compare
Member
Author
|
According to Ikey, the legacy usysconf only stores the glob matches in the state. Should we do the same instead of walking file trees for possibly no reason? |
Member
Yes, that makes senses to me. @livingsilver94: opinions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where potentially the entire
/usr/libtree is added to the state map, adding hundreds of thousands of entries. This attempts to only recurse one subdirectory to try to match what the C usysconf did.With this commit, a first run only adds roughly 6200 entries. Still far higher than previous usysconf's 400, but at least it doesn't choke on a second run. I suspect a lot of that might also be due to the new triggers.