server : fix dry_sequence_breakers missing from GET /props generation settings#25864
Open
verma8076 wants to merge 1 commit into
Open
server : fix dry_sequence_breakers missing from GET /props generation settings#25864verma8076 wants to merge 1 commit into
verma8076 wants to merge 1 commit into
Conversation
… settings The only_metrics branch of task_params::to_json() (used by GET /props to populate default_generation_settings.params) was missing the dry_sequence_breakers field, while the full completion-response branch already reported it. Every other DRY parameter (dry_multiplier, dry_base, dry_allowed_length, dry_penalty_last_n) was present in both branches. Add the field to the only_metrics branch so that GET /props returns a consistent view of all active sampling parameters. Add a test assertion in test_server_props() to prevent regression.
|
Hi @verma8076, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
only_metricsbranch oftask_params::to_json()- used byGET /propsto populatedefault_generation_settings.params- was missing thedry_sequence_breakersfield.The full completion-response branch already reported it correctly. All other DRY parameters (
dry_multiplier,dry_base,dry_allowed_length,dry_penalty_last_n) were present in both branches, so this is an oversight from when the field was originally added to the second branch without being added to the first.This means
GET /propsgives an incomplete view of the active DRY sampler configuration, making it inconsistent with the completion response'sgeneration_settings.Discovered while reviewing the same area of code as #25803.
Changes
tools/server/server-task.cpp: adddry_sequence_breakersto theonly_metricsblock, matching its position afterdry_penalty_last_nin the full block.tools/server/tests/unit/test_basic.py: add an assertion totest_server_props()thatdry_sequence_breakersis present indefault_generation_settings.params.Verification