Skip to content

server : fix dry_sequence_breakers missing from GET /props generation settings#25864

Open
verma8076 wants to merge 1 commit into
ggml-org:masterfrom
verma8076:fix/server-props-dry-sequence-breakers
Open

server : fix dry_sequence_breakers missing from GET /props generation settings#25864
verma8076 wants to merge 1 commit into
ggml-org:masterfrom
verma8076:fix/server-props-dry-sequence-breakers

Conversation

@verma8076

Copy link
Copy Markdown

Problem

The only_metrics branch of task_params::to_json() - used by GET /props to populate default_generation_settings.params - was missing the dry_sequence_breakers field.

The full completion-response branch already reported it correctly. All other DRY parameters (dry_multiplier, dry_base, dry_allowed_length, dry_penalty_last_n) were present in both branches, so this is an oversight from when the field was originally added to the second branch without being added to the first.

This means GET /props gives an incomplete view of the active DRY sampler configuration, making it inconsistent with the completion response's generation_settings.

Discovered while reviewing the same area of code as #25803.

Changes

  • tools/server/server-task.cpp: add dry_sequence_breakers to the only_metrics block, matching its position after dry_penalty_last_n in the full block.
  • tools/server/tests/unit/test_basic.py: add an assertion to test_server_props() that dry_sequence_breakers is present in default_generation_settings.params.

Verification

curl -s localhost:8080/props | jq '.default_generation_settings.params | has("dry_sequence_breakers")'
# Before: false
# After:  true

… settings

The only_metrics branch of task_params::to_json() (used by GET /props
to populate default_generation_settings.params) was missing the
dry_sequence_breakers field, while the full completion-response branch
already reported it. Every other DRY parameter (dry_multiplier, dry_base,
dry_allowed_length, dry_penalty_last_n) was present in both branches.

Add the field to the only_metrics branch so that GET /props returns a
consistent view of all active sampling parameters.

Add a test assertion in test_server_props() to prevent regression.
@verma8076
verma8076 requested a review from a team as a code owner July 18, 2026 16:03
@ggml-gh-bot

ggml-gh-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown

Hi @verma8076, thanks for your contribution!

Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:

  • PR Template not respected: Please respect the template when creating a new pull request. Make sure to fill out all required sections.

Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant